Re: [PATCH 8/8] qapi: add blockdev-replace command

2021-09-23 Thread Vladimir Sementsov-Ogievskiy
23.09.2021 13:09, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Thanks a lot for reviewing! 20.09.2021 09:44, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add command that can add and remove filters. Key points of functionality: What the command does is

Re: [PATCH 8/8] qapi: add blockdev-replace command

2021-09-23 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Thanks a lot for reviewing! > > 20.09.2021 09:44, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Add command that can add and remove filters. >>> >>> Key points of functionality: >>> >>> What the command does is simply replace

Re: [PATCH 8/8] qapi: add blockdev-replace command

2021-09-20 Thread Vladimir Sementsov-Ogievskiy
02.08.2021 21:54, Vladimir Sementsov-Ogievskiy wrote: Add command that can add and remove filters. Key points of functionality: What the command does is simply replace some BdrvChild.bs by some other nodes. The tricky thing is selecting there BdrvChild objects. To be able to select any kind of

Re: [PATCH 8/8] qapi: add blockdev-replace command

2021-09-20 Thread Vladimir Sementsov-Ogievskiy
Thanks a lot for reviewing! 20.09.2021 09:44, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add command that can add and remove filters. Key points of functionality: What the command does is simply replace some BdrvChild.bs by some other nodes. The tricky thing is selecting

Re: [PATCH 8/8] qapi: add blockdev-replace command

2021-09-20 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Add command that can add and remove filters. > > Key points of functionality: > > What the command does is simply replace some BdrvChild.bs by some other > nodes. The tricky thing is selecting there BdrvChild objects. > To be able to select any kind of

[PATCH 8/8] qapi: add blockdev-replace command

2021-08-02 Thread Vladimir Sementsov-Ogievskiy
Add command that can add and remove filters. Key points of functionality: What the command does is simply replace some BdrvChild.bs by some other nodes. The tricky thing is selecting there BdrvChild objects. To be able to select any kind of BdrvChild we use a generic parent_id, which may be a