Re: [PATCH 8/9] qemu, libxl, hypervisor: use virDomainDriverNodeDeviceDetachFlags() helper

2021-02-02 Thread Daniel Henrique Barboza
On 2/2/21 1:35 PM, Daniel P. Berrangé wrote: The check-aclrules.py script has some logic which looks to see if the method contains a function call that resolves to another public API entrypoint, as a special case. So basically we'll need to process the hypervisor_driver.c file to extract a

Re: [PATCH 8/9] qemu, libxl, hypervisor: use virDomainDriverNodeDeviceDetachFlags() helper

2021-02-02 Thread Daniel Henrique Barboza
On 2/2/21 1:35 PM, Daniel P. Berrangé wrote: On Tue, Feb 02, 2021 at 05:32:14PM +0100, Ján Tomko wrote: On a Tuesday in 2021, Daniel P. Berrangé wrote: On Tue, Feb 02, 2021 at 05:18:51PM +0100, Ján Tomko wrote: On a Monday in 2021, Daniel Henrique Barboza wrote:

Re: [PATCH 8/9] qemu, libxl, hypervisor: use virDomainDriverNodeDeviceDetachFlags() helper

2021-02-02 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 05:32:14PM +0100, Ján Tomko wrote: > On a Tuesday in 2021, Daniel P. Berrangé wrote: > > On Tue, Feb 02, 2021 at 05:18:51PM +0100, Ján Tomko wrote: > > > On a Monday in 2021, Daniel Henrique Barboza wrote: > > > > libxlNodeDeviceDetachFlags() and qemuNodeDeviceDetachFlags()

Re: [PATCH 8/9] qemu, libxl, hypervisor: use virDomainDriverNodeDeviceDetachFlags() helper

2021-02-02 Thread Ján Tomko
On a Tuesday in 2021, Daniel P. Berrangé wrote: On Tue, Feb 02, 2021 at 05:18:51PM +0100, Ján Tomko wrote: On a Monday in 2021, Daniel Henrique Barboza wrote: > libxlNodeDeviceDetachFlags() and qemuNodeDeviceDetachFlags() are mostly > equal, aside from how the virHostdevmanager pointer is

Re: [PATCH 8/9] qemu, libxl, hypervisor: use virDomainDriverNodeDeviceDetachFlags() helper

2021-02-02 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 05:18:51PM +0100, Ján Tomko wrote: > On a Monday in 2021, Daniel Henrique Barboza wrote: > > libxlNodeDeviceDetachFlags() and qemuNodeDeviceDetachFlags() are mostly > > equal, aside from how the virHostdevmanager pointer is retrieved and > > the PCI stub driver used. > > >

Re: [PATCH 8/9] qemu, libxl, hypervisor: use virDomainDriverNodeDeviceDetachFlags() helper

2021-02-02 Thread Ján Tomko
On a Monday in 2021, Daniel Henrique Barboza wrote: libxlNodeDeviceDetachFlags() and qemuNodeDeviceDetachFlags() are mostly equal, aside from how the virHostdevmanager pointer is retrieved and the PCI stub driver used. Now that the PCI stub driver verification is done early in both functions,

[PATCH 8/9] qemu, libxl, hypervisor: use virDomainDriverNodeDeviceDetachFlags() helper

2021-02-01 Thread Daniel Henrique Barboza
libxlNodeDeviceDetachFlags() and qemuNodeDeviceDetachFlags() are mostly equal, aside from how the virHostdevmanager pointer is retrieved and the PCI stub driver used. Now that the PCI stub driver verification is done early in both functions, we can use the virDomainDriverNodeDeviceDetachFlags()