Re: [PATCH 9/9] WIP: Add tool for probing images

2020-02-19 Thread Peter Krempa
On Wed, Feb 19, 2020 at 10:31:18 -0600, Eric Blake wrote: > On 2/17/20 11:13 AM, Peter Krempa wrote: > > Note that this is not finished yet, but allows to test the image > > detection patches: > > "allows to ${verb}" is not idiomatic; you want "allows ${verb}ing" or > "allows $subject to ${verb}".

Re: [PATCH 9/9] WIP: Add tool for probing images

2020-02-19 Thread Eric Blake
On 2/17/20 11:13 AM, Peter Krempa wrote: Note that this is not finished yet, but allows to test the image detection patches: "allows to ${verb}" is not idiomatic; you want "allows ${verb}ing" or "allows $subject to ${verb}". Here, I would go with "allows testing of the image detection patche

[PATCH 9/9] WIP: Add tool for probing images

2020-02-17 Thread Peter Krempa
Note that this is not finished yet, but allows to test the image detection patches: Prepare few images: qemu-img create -f qcow2 /tmp/base.qcow2 10M qemu-img create -f qcow2 -b /tmp/base.qcow2 /tmp/overlay1-noformat.qcow2 qemu-img create -f qcow2 -F qcow2 -b /tmp/base.qcow2 /tmp/overlay1