Re: [PATCH RESEND 1/5] virCommand: Actually acquire pidfile instead of just writing it

2020-03-23 Thread Marc-André Lureau
Hi On Mon, Mar 23, 2020 at 5:14 PM Michal Privoznik wrote: > > Our virCommand module allows us to set a pidfile for commands we > want to spawn. The caller constructs the string of pidfile path > and then uses virCommandSetPidFile() to tell the module to write > the pidfile once the command is r

[PATCH RESEND 1/5] virCommand: Actually acquire pidfile instead of just writing it

2020-03-23 Thread Michal Privoznik
Our virCommand module allows us to set a pidfile for commands we want to spawn. The caller constructs the string of pidfile path and then uses virCommandSetPidFile() to tell the module to write the pidfile once the command is ran. This usually works, but has two flaws: 1) the child process does no