Re: [PATCH RESEND 20/20] virhostdev.c: remove missing PCI devs from hostdev manager

2021-02-22 Thread Laine Stump
On 2/22/21 4:11 PM, Daniel Henrique Barboza wrote: I learned this 20+ years ago and forgot it along the road. Heavy metal lyrics and World of Warcraft public chat aren't the best sources for learning proper English grammar, so it seems. I learned Turkish from taxi drivers and random people at

Re: [PATCH RESEND 20/20] virhostdev.c: remove missing PCI devs from hostdev manager

2021-02-22 Thread Daniel Henrique Barboza
On 2/22/21 1:12 AM, Laine Stump wrote: On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote: virHostdevReAttachPCIDevices() is called when we want to re-attach a list of hostdevs back to the host, either on the shutdown path or via a 'virsh detach-device' call.  This function always count on

Re: [PATCH RESEND 20/20] virhostdev.c: remove missing PCI devs from hostdev manager

2021-02-21 Thread Laine Stump
On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote: virHostdevReAttachPCIDevices() is called when we want to re-attach a list of hostdevs back to the host, either on the shutdown path or via a 'virsh detach-device' call. This function always count on the existence of the device in the host to

[PATCH RESEND 20/20] virhostdev.c: remove missing PCI devs from hostdev manager

2021-01-18 Thread Daniel Henrique Barboza
virHostdevReAttachPCIDevices() is called when we want to re-attach a list of hostdevs back to the host, either on the shutdown path or via a 'virsh detach-device' call. This function always count on the existence of the device in the host to work, but this can lead to problems. For example, a