Re: [PATCH RESEND v3 8/8] libvirt.spec: drop no longer required build dependencies

2021-05-26 Thread Andrea Bolognani
On Tue, May 25, 2021 at 10:19:28PM -0400, Neal Gompa wrote: > On Tue, May 25, 2021 at 11:34 AM Andrea Bolognani wrote: > > On Tue, May 25, 2021 at 05:06:41PM +0200, Michal Prívozník wrote: > > > Wasn't the whole idea to drop dependencies? > > > > The point was to drop **build** dependencies, speci

Re: [PATCH RESEND v3 8/8] libvirt.spec: drop no longer required build dependencies

2021-05-25 Thread Neal Gompa
On Tue, May 25, 2021 at 11:34 AM Andrea Bolognani wrote: > > On Tue, May 25, 2021 at 05:06:41PM +0200, Michal Prívozník wrote: > > On 5/25/21 12:00 PM, Andrea Bolognani wrote: > > > On Tue, May 25, 2021 at 10:00:47AM +0200, Pavel Hrdina wrote: > > >> -# For storage wiping with different algorithms

Re: [PATCH RESEND v3 8/8] libvirt.spec: drop no longer required build dependencies

2021-05-25 Thread Andrea Bolognani
On Tue, May 25, 2021 at 05:06:41PM +0200, Michal Prívozník wrote: > On 5/25/21 12:00 PM, Andrea Bolognani wrote: > > On Tue, May 25, 2021 at 10:00:47AM +0200, Pavel Hrdina wrote: > >> -# For storage wiping with different algorithms > >> -BuildRequires: scrub > > > > Turns out we're actually missing

Re: [PATCH RESEND v3 8/8] libvirt.spec: drop no longer required build dependencies

2021-05-25 Thread Michal Prívozník
On 5/25/21 12:00 PM, Andrea Bolognani wrote: > On Tue, May 25, 2021 at 10:00:47AM +0200, Pavel Hrdina wrote: >> -# For mount/umount in FS driver >> -BuildRequires: util-linux > > This BuildRequires is duplicated, so please drop the other instance > as well. > >> -# For storage wiping with differe

Re: [PATCH RESEND v3 8/8] libvirt.spec: drop no longer required build dependencies

2021-05-25 Thread Andrea Bolognani
On Tue, May 25, 2021 at 10:00:47AM +0200, Pavel Hrdina wrote: > -# For mount/umount in FS driver > -BuildRequires: util-linux This BuildRequires is duplicated, so please drop the other instance as well. > -# For storage wiping with different algorithms > -BuildRequires: scrub Turns out we're act

[PATCH RESEND v3 8/8] libvirt.spec: drop no longer required build dependencies

2021-05-25 Thread Pavel Hrdina
These are no longer required to build libvirt as they are used during compilation only by meson to detect if some "auto" features should be enabled or not but in spec file we explicitly enable/disable all libvirt features. Signed-off-by: Pavel Hrdina --- libvirt.spec.in | 31