Re: [PATCH for-6.0] accel: Wire accel to /machine

2020-12-08 Thread Peter Krempa
On Tue, Dec 08, 2020 at 11:13:07 +0300, Roman Bolshakov wrote: > On Mon, Dec 07, 2020 at 06:50:07PM +0100, Peter Krempa wrote: > > On Mon, Dec 07, 2020 at 12:38:49 -0500, Eduardo Habkost wrote: > > > On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote: > > > > There's no generic way to

Re: [PATCH for-6.0] accel: Wire accel to /machine

2020-12-08 Thread Roman Bolshakov
On Mon, Dec 07, 2020 at 06:50:07PM +0100, Peter Krempa wrote: > On Mon, Dec 07, 2020 at 12:38:49 -0500, Eduardo Habkost wrote: > > On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote: > > > There's no generic way to query current accel and its properties via QOM > > > because there's

Re: [PATCH for-6.0] accel: Wire accel to /machine

2020-12-08 Thread Roman Bolshakov
On Mon, Dec 07, 2020 at 12:38:49PM -0500, Eduardo Habkost wrote: > On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote: > > There's no generic way to query current accel and its properties via QOM > > because there's no link between an accel and current machine. > > > > The change

Re: [PATCH for-6.0] accel: Wire accel to /machine

2020-12-07 Thread Roman Bolshakov
On Mon, Dec 07, 2020 at 05:44:19PM +, Daniel P. Berrangé wrote: > On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote: > > An outstanding issue is whether management applications can rely on the > > value of /machine/accel/type and output of qom-list-types command [2][3] > > to

Re: [PATCH for-6.0] accel: Wire accel to /machine

2020-12-07 Thread Peter Krempa
On Mon, Dec 07, 2020 at 12:38:49 -0500, Eduardo Habkost wrote: > On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote: > > There's no generic way to query current accel and its properties via QOM > > because there's no link between an accel and current machine. > > > > The change adds

Re: [PATCH for-6.0] accel: Wire accel to /machine

2020-12-07 Thread Daniel P . Berrangé
On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote: > There's no generic way to query current accel and its properties via QOM > because there's no link between an accel and current machine. > > The change adds the link, i.e. if HVF is enabled the following will be > available in

Re: [PATCH for-6.0] accel: Wire accel to /machine

2020-12-07 Thread Eduardo Habkost
On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote: > There's no generic way to query current accel and its properties via QOM > because there's no link between an accel and current machine. > > The change adds the link, i.e. if HVF is enabled the following will be > available in

[PATCH for-6.0] accel: Wire accel to /machine

2020-12-07 Thread Roman Bolshakov
There's no generic way to query current accel and its properties via QOM because there's no link between an accel and current machine. The change adds the link, i.e. if HVF is enabled the following will be available in QOM: (qemu) qom-get /machine/accel type "hvf-accel" Suggested-by: Markus