Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-30 Thread Markus Armbruster
Peter Krempa writes: > On Mon, Nov 30, 2020 at 10:21:08 +0100, Markus Armbruster wrote: >> Peter Krempa writes: >> >> > On Fri, Nov 27, 2020 at 16:44:05 +0100, Markus Armbruster wrote: >> >> Peter Krempa writes: > > [...] > >> > I know it's hard to enforce, but probably the cheapest in terms

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-30 Thread Eric Blake
On 11/27/20 10:30 AM, Peter Krempa wrote: > On Fri, Nov 27, 2020 at 16:44:05 +0100, Markus Armbruster wrote: >> Peter Krempa writes: >> >>> On Fri, Nov 27, 2020 at 14:45:12 +0300, Roman Bolshakov wrote: On Fri, Nov 27, 2020 at 12:21:54PM +0100, Peter Krempa wrote: > > [...] > >>> As you

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-30 Thread Peter Krempa
On Mon, Nov 30, 2020 at 10:21:08 +0100, Markus Armbruster wrote: > Peter Krempa writes: > > > On Fri, Nov 27, 2020 at 16:44:05 +0100, Markus Armbruster wrote: > >> Peter Krempa writes: [...] > > I know it's hard to enforce, but probably the cheapest in terms of > > drawbacks any other

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-30 Thread Markus Armbruster
Peter Krempa writes: > On Fri, Nov 27, 2020 at 16:44:05 +0100, Markus Armbruster wrote: >> Peter Krempa writes: >> >> > On Fri, Nov 27, 2020 at 14:45:12 +0300, Roman Bolshakov wrote: >> >> On Fri, Nov 27, 2020 at 12:21:54PM +0100, Peter Krempa wrote: > > [...] > >> > As you can see this has

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-27 Thread Peter Krempa
On Fri, Nov 27, 2020 at 15:53:16 +, Daniel Berrange wrote: > On Fri, Nov 27, 2020 at 01:18:09PM +0100, Peter Krempa wrote: > > On Fri, Nov 27, 2020 at 14:45:12 +0300, Roman Bolshakov wrote: [...] > IIUC, this all relies on us importing a dump of the latest QEMU > capabilities into the

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-27 Thread Peter Krempa
On Fri, Nov 27, 2020 at 16:44:05 +0100, Markus Armbruster wrote: > Peter Krempa writes: > > > On Fri, Nov 27, 2020 at 14:45:12 +0300, Roman Bolshakov wrote: > >> On Fri, Nov 27, 2020 at 12:21:54PM +0100, Peter Krempa wrote: [...] > > As you can see this has an issue when we have to add

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-27 Thread Daniel P . Berrangé
On Fri, Nov 27, 2020 at 01:18:09PM +0100, Peter Krempa wrote: > On Fri, Nov 27, 2020 at 14:45:12 +0300, Roman Bolshakov wrote: > > On Fri, Nov 27, 2020 at 12:21:54PM +0100, Peter Krempa wrote: > > > On Fri, Nov 27, 2020 at 10:50:59 +, Daniel Berrange wrote: > > > > Copying libvir-list for the

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-27 Thread Markus Armbruster
Peter Krempa writes: > On Fri, Nov 27, 2020 at 14:45:12 +0300, Roman Bolshakov wrote: >> On Fri, Nov 27, 2020 at 12:21:54PM +0100, Peter Krempa wrote: >> > On Fri, Nov 27, 2020 at 10:50:59 +, Daniel Berrange wrote: >> > > Copying libvir-list for the deprecation warning. >> > > >> > > >> >

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-27 Thread Peter Krempa
On Fri, Nov 27, 2020 at 14:45:12 +0300, Roman Bolshakov wrote: > On Fri, Nov 27, 2020 at 12:21:54PM +0100, Peter Krempa wrote: > > On Fri, Nov 27, 2020 at 10:50:59 +, Daniel Berrange wrote: > > > Copying libvir-list for the deprecation warning. > > > > > > > > > On Mon, Nov 16, 2020 at

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-27 Thread Roman Bolshakov
On Fri, Nov 27, 2020 at 12:21:54PM +0100, Peter Krempa wrote: > On Fri, Nov 27, 2020 at 10:50:59 +, Daniel Berrange wrote: > > Copying libvir-list for the deprecation warning. > > > > > > On Mon, Nov 16, 2020 at 04:10:11PM +0300, Roman Bolshakov wrote: > > > 'query-accel' QMP command should

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-27 Thread Peter Krempa
On Fri, Nov 27, 2020 at 10:50:59 +, Daniel Berrange wrote: > Copying libvir-list for the deprecation warning. > > > On Mon, Nov 16, 2020 at 04:10:11PM +0300, Roman Bolshakov wrote: > > 'query-accel' QMP command should be used instead. > > > > Signed-off-by: Roman Bolshakov > > --- > >

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-27 Thread Daniel P . Berrangé
Copying libvir-list for the deprecation warning. On Mon, Nov 16, 2020 at 04:10:11PM +0300, Roman Bolshakov wrote: > 'query-accel' QMP command should be used instead. > > Signed-off-by: Roman Bolshakov > --- > qapi/machine.json | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-)