Re: [PATCH resend] virfile: Replace AbsPath judgement method with g_path_is_absolute()

2021-04-13 Thread Luke Yue
OK, I got it, thanks! Zelong Michal Privoznik 于2021年4月13日周二 下午9:40写道: > > On 4/13/21 3:38 PM, Luke Yue wrote: > > Thanks for the review! > > > > I will look into them in my spare time, and I have a small question. > > Do I need to create a series of little patches? Cause the files that > > need

Re: [PATCH resend] virfile: Replace AbsPath judgement method with g_path_is_absolute()

2021-04-13 Thread Michal Privoznik
On 4/13/21 3:38 PM, Luke Yue wrote: Thanks for the review! I will look into them in my spare time, and I have a small question. Do I need to create a series of little patches? Cause the files that need the treatment belong to different parts of the libvirt. Or just squash them into one commit be

Re: [PATCH resend] virfile: Replace AbsPath judgement method with g_path_is_absolute()

2021-04-13 Thread Luke Yue
Thanks for the review! I will look into them in my spare time, and I have a small question. Do I need to create a series of little patches? Cause the files that need the treatment belong to different parts of the libvirt. Or just squash them into one commit because the changes are not that large?

Re: [PATCH resend] virfile: Replace AbsPath judgement method with g_path_is_absolute()

2021-04-13 Thread Michal Privoznik
On 4/12/21 4:04 PM, Luke Yue wrote: The g_path_is_absolute() considers more situations than just a simply "path[0] == '/'". Related issue: https://gitlab.com/libvirt/libvirt/-/issues/12 Signed-off-by: Luke Yue --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH resend] virfile: Replace AbsPath judgement method with g_path_is_absolute()

2021-04-12 Thread Luke Yue
The g_path_is_absolute() considers more situations than just a simply "path[0] == '/'". Related issue: https://gitlab.com/libvirt/libvirt/-/issues/12 Signed-off-by: Luke Yue --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/