Re: [PATCH v1] remove sysconfig files

2021-07-22 Thread Olaf Hering
Am Wed, 21 Jul 2021 12:36:40 +0100 schrieb Daniel P. Berrangé : > If we remove the sysconfig files, we're not expecting users to > modify the .service files. Instead they will be using the systemd > overrides in /etc/systemd/system/libvirtd.service.d/ to > customize. It seems docs/daemons.rst

Re: [PATCH v1] remove sysconfig files

2021-07-22 Thread Olaf Hering
Am Wed, 21 Jul 2021 06:00:12 -0700 schrieb Andrea Bolognani : > On Wed, Jul 21, 2021 at 01:23:56PM +0200, Olaf Hering wrote: > > There is no point in restarting libvirtd in the middle of the transaction. > > The spec file gives no ordering hints to rpm. > Note that the daemon restart always

Re: [PATCH v1] remove sysconfig files

2021-07-21 Thread Daniel P . Berrangé
On Wed, Jul 21, 2021 at 10:13:32AM -0400, Andrea Bolognani wrote: > On Wed, Jul 21, 2021 at 02:07:58PM +0100, Daniel P. Berrangé wrote: > > On Wed, Jul 21, 2021 at 03:16:39AM -0700, Andrea Bolognani wrote: > > > Also pre-existing: do we even care about handling upgrades from > > > versions of the

Re: [PATCH v1] remove sysconfig files

2021-07-21 Thread Andrea Bolognani
On Wed, Jul 21, 2021 at 02:07:58PM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 21, 2021 at 03:16:39AM -0700, Andrea Bolognani wrote: > > Also pre-existing: do we even care about handling upgrades from > > versions of the daemon that didn't have support for systemd socket > > passing at this

Re: [PATCH v1] remove sysconfig files

2021-07-21 Thread Olaf Hering
Am Wed, 21 Jul 2021 06:00:12 -0700 schrieb Andrea Bolognani : > For most software, the default configuration files consist of mostly > comments and act more like documentation for what the local > configuration might look like. Claiming that the defaults are > actually defined in the source code

Re: [PATCH v1] remove sysconfig files

2021-07-21 Thread Daniel P . Berrangé
On Wed, Jul 21, 2021 at 03:16:39AM -0700, Andrea Bolognani wrote: > On Tue, Jul 20, 2021 at 07:00:20PM +0200, Olaf Hering wrote: > > if [ -f %{_localstatedir}/lib/rpm-state/libvirt/restart ]; then > > # See if user has previously modified their install to > > # tell libvirtd to use

Re: [PATCH v1] remove sysconfig files

2021-07-21 Thread Andrea Bolognani
On Wed, Jul 21, 2021 at 01:23:56PM +0200, Olaf Hering wrote: > Am Wed, 21 Jul 2021 03:16:39 -0700 schrieb Andrea Bolognani > : > > On Tue, Jul 20, 2021 at 07:00:20PM +0200, Olaf Hering wrote: > > > sysconfig files are owned by the admin of the host. He has the liberty > > > to put anything he

Re: [PATCH v1] remove sysconfig files

2021-07-21 Thread Andrea Bolognani
On Wed, Jul 21, 2021 at 12:36:40PM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 21, 2021 at 03:16:39AM -0700, Andrea Bolognani wrote: > > In particular, I worry about changes in defaults being more difficult > > for users to detect: in Debian at least, changes to the default > > sysconfig files

Re: [PATCH v1] remove sysconfig files

2021-07-21 Thread Daniel P . Berrangé
On Wed, Jul 21, 2021 at 01:51:01PM +0200, Olaf Hering wrote: > Am Wed, 21 Jul 2021 12:36:40 +0100 > schrieb Daniel P. Berrangé : > > > If we remove the sysconfig files, we're not expecting users to > > modify the .service files. Instead they will be using the systemd > > overrides in

Re: [PATCH v1] remove sysconfig files

2021-07-21 Thread Olaf Hering
Am Wed, 21 Jul 2021 12:36:40 +0100 schrieb Daniel P. Berrangé : > If we remove the sysconfig files, we're not expecting users to > modify the .service files. Instead they will be using the systemd > overrides in /etc/systemd/system/libvirtd.service.d/ to > customize. Why not /etc/sysconfig/file

Re: [PATCH v1] remove sysconfig files

2021-07-21 Thread Daniel P . Berrangé
On Wed, Jul 21, 2021 at 03:16:39AM -0700, Andrea Bolognani wrote: > On Tue, Jul 20, 2021 at 07:00:20PM +0200, Olaf Hering wrote: > In particular, I worry about changes in defaults being more difficult > for users to detect: in Debian at least, changes to the default > sysconfig files result in the

Re: [PATCH v1] remove sysconfig files

2021-07-21 Thread Olaf Hering
Am Wed, 21 Jul 2021 03:16:39 -0700 schrieb Andrea Bolognani : > On Tue, Jul 20, 2021 at 07:00:20PM +0200, Olaf Hering wrote: > > sysconfig files are owned by the admin of the host. He has the liberty > > to put anything he wants into these files. This makes it difficult to > > provide different

Re: [PATCH v1] remove sysconfig files

2021-07-21 Thread Andrea Bolognani
On Tue, Jul 20, 2021 at 07:00:20PM +0200, Olaf Hering wrote: > sysconfig files are owned by the admin of the host. He has the liberty > to put anything he wants into these files. This makes it difficult to > provide different built-in defaults. s/He has/They have/ s/he wants/they want/ > +++

Re: [PATCH v1] remove sysconfig files

2021-07-20 Thread Olaf Hering
Am Tue, 20 Jul 2021 19:00:20 +0200 schrieb Olaf Hering : > +#Environment=QEMU_AUDIO_DRV=sdl > +#Environment=SDL_AUDIODRIVER=pulse These two knobs are undocumented. Instead of dropping them I decided to put them into the service files. I do not know if both are intended for a wider audience, or

[PATCH v1] remove sysconfig files

2021-07-20 Thread Olaf Hering
sysconfig files are owned by the admin of the host. He has the liberty to put anything he wants into these files. This makes it difficult to provide different built-in defaults. Remove the sysconfig file and place the current desired default into the service file. Local customizations can now go