Re: [PATCH v1 00/12] Bhyve driver improvements

2020-02-24 Thread Ryan Moeller
Awesome, thank you! I'll try to address the remaining feedback when I get a chance. This work isn't exactly my primary job function so it's been more of a nights and weekends labor of love kind of thing. Thanks again for taking the time to review and push these patches! On Mon, Feb 24, 2020 at 1

Re: [PATCH v1 00/12] Bhyve driver improvements

2020-02-24 Thread Daniel P . Berrangé
On Mon, Feb 24, 2020 at 01:46:12AM -0500, Ryan Moeller wrote: > Rebased and updated from previous patch set to address feedback: > > * Tried to match local convention for subjects where obvious > * Split patch 01 into two patches, with updated messages > * Use g_autofree to fix use after free i

[PATCH v1 00/12] Bhyve driver improvements

2020-02-23 Thread Ryan Moeller
Rebased and updated from previous patch set to address feedback: * Tried to match local convention for subjects where obvious * Split patch 01 into two patches, with updated messages * Use g_autofree to fix use after free in conf/virnetworkobj * Add missing newline in one of the tests args fil