Re: [PATCH v1 3/4] domain_conf.c: auto-align pSeries NVDIMM in virDomainMemoryDefParseXML()

2020-09-17 Thread Andrea Bolognani
On Mon, 2020-09-14 at 23:42 -0300, Daniel Henrique Barboza wrote: > @@ -16981,23 +17000,11 @@ virDomainMemoryDefParseXML(virDomainXMLOptionPtr > xmlopt, > +if (virDomainNVDimmAlignSizePseries(def) < 0) > +goto error; The outcome of this change is good, and overall it doesn't n

[PATCH v1 3/4] domain_conf.c: auto-align pSeries NVDIMM in virDomainMemoryDefParseXML()

2020-09-14 Thread Daniel Henrique Barboza
The alignment for the pSeries NVDIMM does not depend on runtime constraints. This means that it can be done in device parse time, instead of runtime, allowing the domain XML to reflect what the auto-alignment would do when the domain starts. This brings consistency between the NVDIMM size reported