Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

2022-01-04 Thread Rohit Kumar
On 04/01/22 3:56 pm, Ani Sinha wrote: On Tue, 4 Jan 2022, Peter Krempa wrote: On Tue, Jan 04, 2022 at 15:30:00 +0530, Ani Sinha wrote: On Tue, 4 Jan 2022, Rohit Kumar wrote: On 03/01/22 7:12 pm, Ani Sinha wrote: On Wed, 22 Dec 2021, Rohit Kumar wrote: [...] @@ -694,6 +702,7 @@ qemuMoni

Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

2022-01-04 Thread Ani Sinha
On Tue, 4 Jan 2022, Peter Krempa wrote: > On Tue, Jan 04, 2022 at 15:30:00 +0530, Ani Sinha wrote: > > On Tue, 4 Jan 2022, Rohit Kumar wrote: > > > On 03/01/22 7:12 pm, Ani Sinha wrote: > > > > On Wed, 22 Dec 2021, Rohit Kumar wrote: > > [...] > > > > > > @@ -694,6 +702,7 @@ qemuMonitorOpenInte

Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

2022-01-04 Thread Peter Krempa
On Tue, Jan 04, 2022 at 15:30:00 +0530, Ani Sinha wrote: > On Tue, 4 Jan 2022, Rohit Kumar wrote: > > On 03/01/22 7:12 pm, Ani Sinha wrote: > > > On Wed, 22 Dec 2021, Rohit Kumar wrote: [...] > > > > @@ -694,6 +702,7 @@ qemuMonitorOpenInternal(virDomainObj *vm, > > > > mon->fd = fd; > > > >

Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

2022-01-04 Thread Ani Sinha
On Tue, 4 Jan 2022, Rohit Kumar wrote: > > On 03/01/22 7:12 pm, Ani Sinha wrote: > > > > On Wed, 22 Dec 2021, Rohit Kumar wrote: > > > > > This patch is to determine the VM which had IO or socket hangup error. > > > Accessing directly vm->def->name inside qemuMonitorIO() or > > > qemuMonitorSen

Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

2022-01-04 Thread Rohit Kumar
On 04/01/22 2:17 pm, Peter Krempa wrote: On Tue, Jan 04, 2022 at 09:45:30 +0100, Peter Krempa wrote: On Tue, Jan 04, 2022 at 14:10:49 +0530, Rohit Kumar wrote: On 03/01/22 10:12 pm, Peter Krempa wrote: On Wed, Dec 22, 2021 at 22:39:21 -0800, Rohit Kumar wrote: This patch is to determine the

Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

2022-01-04 Thread Peter Krempa
On Tue, Jan 04, 2022 at 09:45:30 +0100, Peter Krempa wrote: > On Tue, Jan 04, 2022 at 14:10:49 +0530, Rohit Kumar wrote: > > > > On 03/01/22 10:12 pm, Peter Krempa wrote: > > > On Wed, Dec 22, 2021 at 22:39:21 -0800, Rohit Kumar wrote: > > > > This patch is to determine the VM which had IO or sock

Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

2022-01-04 Thread Peter Krempa
On Tue, Jan 04, 2022 at 14:10:49 +0530, Rohit Kumar wrote: > > On 03/01/22 10:12 pm, Peter Krempa wrote: > > On Wed, Dec 22, 2021 at 22:39:21 -0800, Rohit Kumar wrote: > > > This patch is to determine the VM which had IO or socket hangup error. > > > Accessing directly vm->def->name inside qemuMon

Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

2022-01-04 Thread Rohit Kumar
On 03/01/22 10:12 pm, Peter Krempa wrote: On Wed, Dec 22, 2021 at 22:39:21 -0800, Rohit Kumar wrote: This patch is to determine the VM which had IO or socket hangup error. Accessing directly vm->def->name inside qemuMonitorIO() or qemuMonitorSend() might leads to illegal access as we are out o

Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

2022-01-04 Thread Rohit Kumar
On 03/01/22 7:12 pm, Ani Sinha wrote: On Wed, 22 Dec 2021, Rohit Kumar wrote: This patch is to determine the VM which had IO or socket hangup error. Accessing directly vm->def->name inside qemuMonitorIO() or qemuMonitorSend() might leads to illegal access as we are out of 'vm' context and vm

Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

2022-01-03 Thread Peter Krempa
On Wed, Dec 22, 2021 at 22:39:21 -0800, Rohit Kumar wrote: > This patch is to determine the VM which had IO or socket hangup error. > Accessing directly vm->def->name inside qemuMonitorIO() or qemuMonitorSend() > might leads to illegal access as we are out of 'vm' context and vm->def might > not ex

Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

2022-01-03 Thread Ani Sinha
On Wed, 22 Dec 2021, Rohit Kumar wrote: > This patch is to determine the VM which had IO or socket hangup error. > Accessing directly vm->def->name inside qemuMonitorIO() or qemuMonitorSend() > might leads to illegal access as we are out of 'vm' context and vm->def might > not exist. Adding a f

Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

2022-01-03 Thread Rohit Kumar
Ping. Please look at this patch. Link: https://listman.redhat.com/archives/libvir-list/2021-December/msg00891.html On 23/12/21 12:09 pm, Rohit Kumar wrote: This patch is to determine the VM which had IO or socket hangup error. Accessing directly vm->def->name inside qemuMonitorIO() or qemuMoni

[PATCH v2] Add VM info to improve error log message for qemu monitor

2021-12-22 Thread Rohit Kumar
This patch is to determine the VM which had IO or socket hangup error. Accessing directly vm->def->name inside qemuMonitorIO() or qemuMonitorSend() might leads to illegal access as we are out of 'vm' context and vm->def might not exist. Adding a field "domainName" inside mon object to access vm nam