[PATCH v2] network: Only check kernel added routes in virNetDevIPCheckIPv6Forwarding

2020-09-11 Thread Ian Wienand
The original motivation for adding virNetDevIPCheckIPv6Forwarding (00d28a78b5d1f6eaf79f06ac59e31c568af9da37) was that networking routes would disappear when ipv6 forwarding was enabled for an interface. This is a fairly undocumented side-effect of the "accept_ra" sysctl for an interface. 1 means

Re: [PATCH v2] network: Only check kernel added routes in virNetDevIPCheckIPv6Forwarding

2020-09-11 Thread Cedric Bosdonnat
Hi Ian, ACK. I've seen a commented VIR_DEBUG though that you surely want to remove before pushing. I also really like the verbose commit message explaining all the reasoning behind the change, thanks for the hard work. -- Cedric On Fri, 2020-09-11 at 21:34 +1000, Ian Wienand wrote: > The origina

Re: [PATCH v2] network: Only check kernel added routes in virNetDevIPCheckIPv6Forwarding

2020-09-11 Thread Laine Stump
On 9/11/20 7:34 AM, Ian Wienand wrote: The original motivation for adding virNetDevIPCheckIPv6Forwarding (00d28a78b5d1f6eaf79f06ac59e31c568af9da37) was that networking routes would disappear when ipv6 forwarding was enabled for an interface. This is a fairly undocumented side-effect of the "acce

Re: [PATCH v2] network: Only check kernel added routes in virNetDevIPCheckIPv6Forwarding

2020-09-13 Thread Laine Stump
On 9/11/20 1:08 PM, Laine Stump wrote: On 9/11/20 7:34 AM, Ian Wienand wrote: The original motivation for adding virNetDevIPCheckIPv6Forwarding (00d28a78b5d1f6eaf79f06ac59e31c568af9da37) was that networking routes would disappear when ipv6 forwarding was enabled for an interface. This is a fair

Re: [PATCH v2] network: Only check kernel added routes in virNetDevIPCheckIPv6Forwarding

2020-09-13 Thread Cedric Bosdonnat
On Sun, 2020-09-13 at 13:34 -0400, Laine Stump wrote: > On 9/11/20 1:08 PM, Laine Stump wrote: > > On 9/11/20 7:34 AM, Ian Wienand wrote: > > > The original motivation for adding virNetDevIPCheckIPv6Forwarding > > > (00d28a78b5d1f6eaf79f06ac59e31c568af9da37) was that networking routes > > > would d