Re: [PATCH v2] qemu: Do not silently allow non-available timers on non-x86 systems

2020-09-02 Thread Daniel P . Berrangé
On Wed, Sep 02, 2020 at 06:23:32PM +0200, Thomas Huth wrote: > On 05/08/2020 12.22, Thomas Huth wrote: > > libvirt currently silently allows and some > > other timer tags in the guest XML definition for timers that do not > > exist on non-x86 systems. We should not silently ignore these tags > >

Re: [PATCH v2] qemu: Do not silently allow non-available timers on non-x86 systems

2020-09-02 Thread Michal Privoznik
On 8/5/20 12:22 PM, Thomas Huth wrote: libvirt currently silently allows and some other timer tags in the guest XML definition for timers that do not exist on non-x86 systems. We should not silently ignore these tags since the users might not get what they expected otherwise. Note: The error is

Re: [PATCH v2] qemu: Do not silently allow non-available timers on non-x86 systems

2020-09-02 Thread Thomas Huth
On 05/08/2020 12.22, Thomas Huth wrote: > libvirt currently silently allows and some > other timer tags in the guest XML definition for timers that do not > exist on non-x86 systems. We should not silently ignore these tags > since the users might not get what they expected otherwise. > Note: The

Re: [PATCH v2] qemu: Do not silently allow non-available timers on non-x86 systems

2020-08-11 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 8/5/20 12:22 PM, Thomas Huth wrote: libvirt currently silently allows and some other timer tags in the guest XML definition for timers that do not exist on non-x86 systems. We should not silently ignore these tags since the users might not get what they

Re: [PATCH v2] qemu: Do not silently allow non-available timers on non-x86 systems

2020-08-07 Thread Daniel Henrique Barboza
On 8/5/20 7:22 AM, Thomas Huth wrote: libvirt currently silently allows and some other timer tags in the guest XML definition for timers that do not exist on non-x86 systems. We should not silently ignore these tags since the users might not get what they expected otherwise. Note: The error

[PATCH v2] qemu: Do not silently allow non-available timers on non-x86 systems

2020-08-05 Thread Thomas Huth
libvirt currently silently allows and some other timer tags in the guest XML definition for timers that do not exist on non-x86 systems. We should not silently ignore these tags since the users might not get what they expected otherwise. Note: The error is only generated if the timer is marked