Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-10-04 Thread Michal Prívozník
On 10/4/22 13:50, Peng Liang wrote: > > > On 10/04/2022 19:43, Michal Prívozník wrote: >> On 10/4/22 12:24, Peng Liang wrote: >>> >>> >>> On 10/03/2022 15:38, Michal Prívozník wrote: On 10/1/22 05:35, Peng Liang wrote: > > > On 09/29/2022 21:31, Michal Prívozník wrote: >> On

Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-10-04 Thread Peng Liang
On 10/04/2022 19:43, Michal Prívozník wrote: On 10/4/22 12:24, Peng Liang wrote: On 10/03/2022 15:38, Michal Prívozník wrote: On 10/1/22 05:35, Peng Liang wrote: On 09/29/2022 21:31, Michal Prívozník wrote: On 9/27/22 17:38, Jiang Jiacheng wrote: From: jiangjiacheng In

Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-10-04 Thread Michal Prívozník
On 10/4/22 12:24, Peng Liang wrote: > > > On 10/03/2022 15:38, Michal Prívozník wrote: >> On 10/1/22 05:35, Peng Liang wrote: >>> >>> >>> On 09/29/2022 21:31, Michal Prívozník wrote: On 9/27/22 17:38, Jiang Jiacheng wrote: > From: jiangjiacheng > > In

Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-10-04 Thread Peng Liang
On 10/03/2022 15:38, Michal Prívozník wrote: On 10/1/22 05:35, Peng Liang wrote: On 09/29/2022 21:31, Michal Prívozník wrote: On 9/27/22 17:38, Jiang Jiacheng wrote: From: jiangjiacheng In virNetServerProgramDispatchCall, The arg is passed as a void* and used to point to a certain

Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-10-03 Thread Michal Prívozník
On 10/1/22 05:35, Peng Liang wrote: > > > On 09/29/2022 21:31, Michal Prívozník wrote: >> On 9/27/22 17:38, Jiang Jiacheng wrote: >>> From: jiangjiacheng >>> >>> In virNetServerProgramDispatchCall, The arg is passed as a void* and >>> used to point >>> to a certain struct depended on the

Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-09-30 Thread Peng Liang
On 09/29/2022 21:31, Michal Prívozník wrote: On 9/27/22 17:38, Jiang Jiacheng wrote: From: jiangjiacheng In virNetServerProgramDispatchCall, The arg is passed as a void* and used to point to a certain struct depended on the dispatcher, so I think it's the memory of the struct's member

Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-09-30 Thread Michal Prívozník
On 9/30/22 04:32, Jiang Jiacheng wrote: > I see, maybe we could free dispatcher->arg_filter and > dispatcher->ret_filter together in error label like this: > error: > if (dispatcher) { > xdr_free(dispatcher->arg_filter, arg); > xdr_free(dispatcher->ret_filter, ret); > } >

Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-09-29 Thread Michal Prívozník
On 9/27/22 17:38, Jiang Jiacheng wrote: > From: jiangjiacheng > > In virNetServerProgramDispatchCall, The arg is passed as a void* and used to > point > to a certain struct depended on the dispatcher, so I think it's the memory of > the > struct's member that leaks and this memory shuld be