Re: [PATCH v2] selinux label: restore all labels when some labels fail to set

2020-11-20 Thread Jin Yan
On 2020/11/20 15:49, Michal Privoznik wrote: On 11/19/20 3:54 PM, Jin Yan wrote: On 2020/11/13 22:33, Michal Privoznik wrote: On 11/13/20 10:47 AM, Jin Yan wrote: Hi Michal, I found this problem while performing migration, based on       libvirt version: 6.2.0       SELinux mode:

Re: [PATCH v2] selinux label: restore all labels when some labels fail to set

2020-11-19 Thread Michal Privoznik
On 11/19/20 3:54 PM, Jin Yan wrote: On 2020/11/13 22:33, Michal Privoznik wrote: On 11/13/20 10:47 AM, Jin Yan wrote: Hi Michal, I found this problem while performing migration, based on       libvirt version: 6.2.0       SELinux mode: permissive Steps: 1. start a vm configured with

Re: [PATCH v2] selinux label: restore all labels when some labels fail to set

2020-11-19 Thread Jin Yan
On 2020/11/13 22:33, Michal Privoznik wrote: On 11/13/20 10:47 AM, Jin Yan wrote: Hi Michal, I found this problem while performing migration, based on     libvirt version: 6.2.0     SELinux mode: permissive Steps: 1. start a vm configured with pipe-type serial port.      

Re: [PATCH v2] selinux label: restore all labels when some labels fail to set

2020-11-13 Thread Michal Privoznik
On 11/13/20 10:47 AM, Jin Yan wrote: Hi Michal, I found this problem while performing migration, based on     libvirt version: 6.2.0     SELinux mode: permissive Steps: 1. start a vm configured with pipe-type serial port.                   2. migrate vm to

Re: [PATCH v2] selinux label: restore all labels when some labels fail to set

2020-11-13 Thread Jin Yan
On 2020/11/13 2:54, Michal Privoznik wrote: On 11/12/20 3:07 PM, Jin Yan wrote: When migration fails, qemuMigrationDstPrepareAny will call qemuProcessStop to restore labels only after all labels are successfully set. If some labels fail to set, the labels that have been set will not be

Re: [PATCH v2] selinux label: restore all labels when some labels fail to set

2020-11-12 Thread Michal Privoznik
On 11/12/20 3:07 PM, Jin Yan wrote: When migration fails, qemuMigrationDstPrepareAny will call qemuProcessStop to restore labels only after all labels are successfully set. If some labels fail to set, the labels that have been set will not be restored. Signed-off-by: Jin Yan ---

[PATCH v2] selinux label: restore all labels when some labels fail to set

2020-11-12 Thread Jin Yan
When migration fails, qemuMigrationDstPrepareAny will call qemuProcessStop to restore labels only after all labels are successfully set. If some labels fail to set, the labels that have been set will not be restored. Signed-off-by: Jin Yan --- src/qemu/qemu_security.c | 12 ++-- 1 file