Re: [PATCH v2] tools: fix iterating over argv when recovering xattr

2021-11-29 Thread Martin Kletzander
On Fri, Nov 26, 2021 at 03:46:56PM +, Daniel P. Berrangé wrote: The libvirt_recover_xattrs.sh tool hangs when run. When not flags s/not/no/ are provided OPTIND is 1, so the loop expands to 'shift 0' which has not effect. Rewrite to just loop over $@ instead which involves less cleverness.

[PATCH v2] tools: fix iterating over argv when recovering xattr

2021-11-26 Thread Daniel P . Berrangé
The libvirt_recover_xattrs.sh tool hangs when run. When not flags are provided OPTIND is 1, so the loop expands to 'shift 0' which has not effect. Rewrite to just loop over $@ instead which involves less cleverness. Signed-off-by: Daniel P. Berrangé --- tools/libvirt_recover_xattrs.sh | 6 +++---