Re: [PATCH v2 0/9] move checks from parse to validate callbacks

2020-12-08 Thread Daniel Henrique Barboza
On 12/8/20 4:58 PM, Michal Privoznik wrote: On 12/8/20 6:45 PM, Daniel Henrique Barboza wrote: On 12/8/20 7:22 AM, Michal Privoznik wrote: But since we are splitting parsing and validation code can we use this chance and move validators out of domain_conf.c allowing it to be smaller

Re: [PATCH v2 0/9] move checks from parse to validate callbacks

2020-12-08 Thread Michal Privoznik
On 12/8/20 6:45 PM, Daniel Henrique Barboza wrote: On 12/8/20 7:22 AM, Michal Privoznik wrote: But since we are splitting parsing and validation code can we use this chance and move validators out of domain_conf.c allowing it to be smaller in size? Makes sense. I can create a

Re: [PATCH v2 0/9] move checks from parse to validate callbacks

2020-12-08 Thread Daniel Henrique Barboza
On 12/8/20 7:22 AM, Michal Privoznik wrote: On 12/7/20 2:54 PM, Daniel Henrique Barboza wrote: Hi, This is the respin of [1] after the reviews from Michal. Although we're pushing code to validate callbacks instead of post parse functions, the idea and motivation is still in line with [2].

Re: [PATCH v2 0/9] move checks from parse to validate callbacks

2020-12-08 Thread Michal Privoznik
On 12/7/20 2:54 PM, Daniel Henrique Barboza wrote: Hi, This is the respin of [1] after the reviews from Michal. Although we're pushing code to validate callbacks instead of post parse functions, the idea and motivation is still in line with [2]. [1]

[PATCH v2 0/9] move checks from parse to validate callbacks

2020-12-07 Thread Daniel Henrique Barboza
Hi, This is the respin of [1] after the reviews from Michal. Although we're pushing code to validate callbacks instead of post parse functions, the idea and motivation is still in line with [2]. [1] https://www.redhat.com/archives/libvir-list/2020-November/msg01409.html [2]