Re: [PATCH v2 00/13] resolve hangs/crashes on libvirtd shutdown

2020-09-07 Thread Nikolay Shirokovskiy
Pushed now. Thanx everyone for review. Patch "[PATCH v2 05/13] rpc: add virNetDaemonSetShutdownCallbacks" does not have mantainer review but I guess it is ok as the patch is simple enough and it's API is used in other patches of series. I would also want to note that crashes are still possibl

Re: [PATCH v2 00/13] resolve hangs/crashes on libvirtd shutdown

2020-09-07 Thread Daniel P . Berrangé
On Mon, Sep 07, 2020 at 10:12:08AM +0300, Nikolay Shirokovskiy wrote: > Pushed now. Thanx everyone for review. > > Patch "[PATCH v2 05/13] rpc: add virNetDaemonSetShutdownCallbacks" does not > have mantainer > review but I guess it is ok as the patch is simple enough and it's API is > used in

Re: [PATCH v2 00/13] resolve hangs/crashes on libvirtd shutdown

2020-09-03 Thread Nikolay Shirokovskiy
one more time Sorry if this is on somebody's yet to be reviewed patches stack. It is not clear now in current workflow if this patch track lost or not. On 06.08.2020 17:10, Nikolay Shirokovskiy wrote: > polite ping > > On 23.07.2020 13:14, Nikolay Shirokovskiy wrote: >> I keep qemu VM event loop

Re: [PATCH v2 00/13] resolve hangs/crashes on libvirtd shutdown

2020-08-06 Thread Nikolay Shirokovskiy
polite ping On 23.07.2020 13:14, Nikolay Shirokovskiy wrote: > I keep qemu VM event loop exiting synchronously but add code to avoid deadlock > that can be caused by this approach. I guess it is worth having synchronous > exiting of threads in this case to avoid crashes. > > Patches that are alre

[PATCH v2 00/13] resolve hangs/crashes on libvirtd shutdown

2020-07-23 Thread Nikolay Shirokovskiy
I keep qemu VM event loop exiting synchronously but add code to avoid deadlock that can be caused by this approach. I guess it is worth having synchronous exiting of threads in this case to avoid crashes. Patches that are already positively reviewed has appropriate 'Reviewed-by' lines. Changes f