Re: [PATCH v2 03/11] conf: Move virDomainGenerateMachineName to hypervisor/

2020-03-30 Thread Daniel P . Berrangé
On Thu, Mar 26, 2020 at 04:15:07PM +0100, Michal Privoznik wrote: > The virDomainGenerateMachineName() function doesn't belong in > src/conf/ really, because it has nothing to do with domain XML > parsing. It landed there because of lack of better place in the > past. But now that we have src/hyper

[PATCH v2 03/11] conf: Move virDomainGenerateMachineName to hypervisor/

2020-03-26 Thread Michal Privoznik
The virDomainGenerateMachineName() function doesn't belong in src/conf/ really, because it has nothing to do with domain XML parsing. It landed there because of lack of better place in the past. But now that we have src/hypervisor/ the function should live there. At the same time, the function name