Re: [PATCH v2 05/17] conf: extend xmlopt with job config & add job object into domain object

2022-09-19 Thread Peter Krempa
On Mon, Sep 19, 2022 at 09:41:57 +0200, Peter Krempa wrote: > On Mon, Sep 19, 2022 at 09:28:28 +0200, Peter Krempa wrote: > > On Mon, Sep 19, 2022 at 09:24:47 +0200, Peter Krempa wrote: > > > On Fri, Sep 16, 2022 at 13:30:07 +0100, Daniel P. Berrangé wrote: > > > > On Mon, Sep 05, 2022 at

Re: [PATCH v2 05/17] conf: extend xmlopt with job config & add job object into domain object

2022-09-19 Thread Peter Krempa
On Mon, Sep 19, 2022 at 09:28:28 +0200, Peter Krempa wrote: > On Mon, Sep 19, 2022 at 09:24:47 +0200, Peter Krempa wrote: > > On Fri, Sep 16, 2022 at 13:30:07 +0100, Daniel P. Berrangé wrote: > > > On Mon, Sep 05, 2022 at 03:57:03PM +0200, Kristina Hanicova wrote: > > [...] > > > A proper fix

Re: [PATCH v2 05/17] conf: extend xmlopt with job config & add job object into domain object

2022-09-19 Thread Peter Krempa
On Mon, Sep 19, 2022 at 09:24:47 +0200, Peter Krempa wrote: > On Fri, Sep 16, 2022 at 13:30:07 +0100, Daniel P. Berrangé wrote: > > On Mon, Sep 05, 2022 at 03:57:03PM +0200, Kristina Hanicova wrote: [...] > A proper fix will be to not rely on stolen pointers though as doing this > is too fragile

Re: [PATCH v2 05/17] conf: extend xmlopt with job config & add job object into domain object

2022-09-19 Thread Peter Krempa
On Fri, Sep 16, 2022 at 13:30:07 +0100, Daniel P. Berrangé wrote: > On Mon, Sep 05, 2022 at 03:57:03PM +0200, Kristina Hanicova wrote: > > This patch adds the generalized job object into the domain object > > so that it can be used by all drivers without the need to extract > > it from the private

Re: [PATCH v2 05/17] conf: extend xmlopt with job config & add job object into domain object

2022-09-16 Thread Daniel P . Berrangé
On Mon, Sep 05, 2022 at 03:57:03PM +0200, Kristina Hanicova wrote: > This patch adds the generalized job object into the domain object > so that it can be used by all drivers without the need to extract > it from the private data. > > Because of this, the job object needs to be created and set >

[PATCH v2 05/17] conf: extend xmlopt with job config & add job object into domain object

2022-09-05 Thread Kristina Hanicova
This patch adds the generalized job object into the domain object so that it can be used by all drivers without the need to extract it from the private data. Because of this, the job object needs to be created and set during the creation of the domain object. This patch also extends xmlopt with