Re: [PATCH v2 1/2] conf: Add option for settings

2020-04-22 Thread Julio Faracco
Em qua., 22 de abr. de 2020 às 10:45, Daniel Henrique Barboza escreveu: > > > > On 4/22/20 9:22 AM, Julio Faracco wrote: > > Hi Daniel, > > > > Thanks for reviewing. :-) > > > Np, glad to be of assistance > > > > IMHO, I don't like to join them in one single patch because it is hard > > to review.

Re: [PATCH v2 1/2] conf: Add option for settings

2020-04-22 Thread Daniel Henrique Barboza
On 4/22/20 9:22 AM, Julio Faracco wrote: Hi Daniel, Thanks for reviewing. :-) Np, glad to be of assistance IMHO, I don't like to join them in one single patch because it is hard to review. Hmm, reading this I believe that the tests would pass after applying patch 2/2 then (didn't try

Re: [PATCH v2 1/2] conf: Add option for settings

2020-04-22 Thread Julio Faracco
Hi Daniel, Thanks for reviewing. :-) IMHO, I don't like to join them in one single patch because it is hard to review. I know that others have a different opinion (and it is good). But I will think about it for v3. -- Julio Cesar Faracco Em qua., 22 de abr. de 2020 às 08:05, Daniel Henrique Barb

Re: [PATCH v2 1/2] conf: Add option for settings

2020-04-22 Thread Daniel Henrique Barboza
On 4/21/20 1:03 AM, Julio Faracco wrote: If an user is trying to configure a dhcp neetwork settings, it is not s/neetwork/network This patch failed to compile in my box on top of master at 9a13704818e: CCLD libvirdeterministichashmock.la ../../tests/networkxml2conftest.c: In funct

[PATCH v2 1/2] conf: Add option for settings

2020-04-20 Thread Julio Faracco
If an user is trying to configure a dhcp neetwork settings, it is not possible to change the leasetime of a range or a host entry. This is available using dnsmasq extra options, but they are associated with dhcp-range or dhcp-hosts fields. This patch implements a leasetime for range and hosts tags.