Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-29 Thread Alex Williamson
On Tue, 28 May 2019 22:57:15 +0200 Boris Fiuczynski wrote: > On 5/14/19 5:31 PM, Alex Williamson wrote: > > On Wed, 8 May 2019 17:27:47 +0200 > > Boris Fiuczynski wrote: > > > >> On 5/8/19 11:22 PM, Alex Williamson wrote: > > I thought there was a request to make this more specific to

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-29 Thread Boris Fiuczynski
On 5/14/19 5:31 PM, Alex Williamson wrote: On Wed, 8 May 2019 17:27:47 +0200 Boris Fiuczynski wrote: On 5/8/19 11:22 PM, Alex Williamson wrote: I thought there was a request to make this more specific to migration by renaming it to something like migration_version. Also, as an so

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-15 Thread Yan Zhao
On Tue, May 14, 2019 at 11:01:42PM +0800, Alex Williamson wrote: > On Tue, 14 May 2019 09:43:44 +0200 > Erik Skultety wrote: > > > On Tue, May 14, 2019 at 03:32:19AM -0400, Yan Zhao wrote: > > > On Tue, May 14, 2019 at 03:20:40PM +0800, Erik Skultety wrote: > > > > On Tue, May 14, 2019 at

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Alex Williamson
On Wed, 8 May 2019 17:27:47 +0200 Boris Fiuczynski wrote: > On 5/8/19 11:22 PM, Alex Williamson wrote: > >>> I thought there was a request to make this more specific to migration > >>> by renaming it to something like migration_version. Also, as an > >>> > >> so this attribute may not only

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Alex Williamson
On Tue, 14 May 2019 09:43:44 +0200 Erik Skultety wrote: > On Tue, May 14, 2019 at 03:32:19AM -0400, Yan Zhao wrote: > > On Tue, May 14, 2019 at 03:20:40PM +0800, Erik Skultety wrote: > > > On Tue, May 14, 2019 at 02:12:35AM -0400, Yan Zhao wrote: > > > > On Mon, May 13, 2019 at 09:28:04PM

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Cornelia Huck
On Tue, 14 May 2019 12:01:45 +0100 "Dr. David Alan Gilbert" wrote: > * Cornelia Huck (coh...@redhat.com) wrote: > > On Tue, 14 May 2019 03:47:36 -0400 > > Yan Zhao wrote: > > > hi Cornelia and Dave, > > > do you also agree on: > > > 1. "not to define the specific errno returned for a specific

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Dr. David Alan Gilbert
* Cornelia Huck (coh...@redhat.com) wrote: > On Tue, 14 May 2019 03:47:36 -0400 > Yan Zhao wrote: > > > On Tue, May 14, 2019 at 03:43:44PM +0800, Erik Skultety wrote: > > > On Tue, May 14, 2019 at 03:32:19AM -0400, Yan Zhao wrote: > > > > On Tue, May 14, 2019 at 03:20:40PM +0800, Erik Skultety

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Erik Skultety
On Tue, May 14, 2019 at 11:51:35AM +0200, Cornelia Huck wrote: > On Tue, 14 May 2019 03:47:36 -0400 > Yan Zhao wrote: > > > On Tue, May 14, 2019 at 03:43:44PM +0800, Erik Skultety wrote: > > > On Tue, May 14, 2019 at 03:32:19AM -0400, Yan Zhao wrote: > > > > On Tue, May 14, 2019 at 03:20:40PM

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Cornelia Huck
On Tue, 14 May 2019 03:47:36 -0400 Yan Zhao wrote: > On Tue, May 14, 2019 at 03:43:44PM +0800, Erik Skultety wrote: > > On Tue, May 14, 2019 at 03:32:19AM -0400, Yan Zhao wrote: > > > On Tue, May 14, 2019 at 03:20:40PM +0800, Erik Skultety wrote: > > > > That said, from libvirt POV as a

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Yan Zhao
On Tue, May 14, 2019 at 03:43:44PM +0800, Erik Skultety wrote: > On Tue, May 14, 2019 at 03:32:19AM -0400, Yan Zhao wrote: > > On Tue, May 14, 2019 at 03:20:40PM +0800, Erik Skultety wrote: > > > On Tue, May 14, 2019 at 02:12:35AM -0400, Yan Zhao wrote: > > > > On Mon, May 13, 2019 at 09:28:04PM

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Erik Skultety
On Tue, May 14, 2019 at 03:32:19AM -0400, Yan Zhao wrote: > On Tue, May 14, 2019 at 03:20:40PM +0800, Erik Skultety wrote: > > On Tue, May 14, 2019 at 02:12:35AM -0400, Yan Zhao wrote: > > > On Mon, May 13, 2019 at 09:28:04PM +0800, Erik Skultety wrote: > > > > On Fri, May 10, 2019 at 11:48:38AM

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Yan Zhao
On Tue, May 14, 2019 at 03:20:40PM +0800, Erik Skultety wrote: > On Tue, May 14, 2019 at 02:12:35AM -0400, Yan Zhao wrote: > > On Mon, May 13, 2019 at 09:28:04PM +0800, Erik Skultety wrote: > > > On Fri, May 10, 2019 at 11:48:38AM +0200, Cornelia Huck wrote: > > > > On Fri, 10 May 2019 10:36:09

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Erik Skultety
On Tue, May 14, 2019 at 02:12:35AM -0400, Yan Zhao wrote: > On Mon, May 13, 2019 at 09:28:04PM +0800, Erik Skultety wrote: > > On Fri, May 10, 2019 at 11:48:38AM +0200, Cornelia Huck wrote: > > > On Fri, 10 May 2019 10:36:09 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Cornelia

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Cornelia Huck
On Tue, 14 May 2019 02:12:35 -0400 Yan Zhao wrote: > On Mon, May 13, 2019 at 09:28:04PM +0800, Erik Skultety wrote: > > In case of libvirt checking the compatibility, it won't matter how good the > > error message in the kernel log is and regardless of how many error states > > you > > want to

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Yan Zhao
On Mon, May 13, 2019 at 09:28:04PM +0800, Erik Skultety wrote: > On Fri, May 10, 2019 at 11:48:38AM +0200, Cornelia Huck wrote: > > On Fri, 10 May 2019 10:36:09 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Cornelia Huck (coh...@redhat.com) wrote: > > > > On Thu, 9 May 2019 17:48:26 +0100

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-13 Thread Erik Skultety
On Fri, May 10, 2019 at 11:48:38AM +0200, Cornelia Huck wrote: > On Fri, 10 May 2019 10:36:09 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Cornelia Huck (coh...@redhat.com) wrote: > > > On Thu, 9 May 2019 17:48:26 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Cornelia Huck

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-12 Thread Yan Zhao
On Fri, May 10, 2019 at 05:48:38PM +0800, Cornelia Huck wrote: > On Fri, 10 May 2019 10:36:09 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Cornelia Huck (coh...@redhat.com) wrote: > > > On Thu, 9 May 2019 17:48:26 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Cornelia Huck

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-10 Thread Cornelia Huck
On Fri, 10 May 2019 10:36:09 +0100 "Dr. David Alan Gilbert" wrote: > * Cornelia Huck (coh...@redhat.com) wrote: > > On Thu, 9 May 2019 17:48:26 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Cornelia Huck (coh...@redhat.com) wrote: > > > > On Thu, 9 May 2019 16:48:57 +0100 > > > >

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-10 Thread Dr. David Alan Gilbert
* Cornelia Huck (coh...@redhat.com) wrote: > On Thu, 9 May 2019 17:48:26 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Cornelia Huck (coh...@redhat.com) wrote: > > > On Thu, 9 May 2019 16:48:57 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Cornelia Huck (coh...@redhat.com)

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-10 Thread Cornelia Huck
On Thu, 9 May 2019 17:48:26 +0100 "Dr. David Alan Gilbert" wrote: > * Cornelia Huck (coh...@redhat.com) wrote: > > On Thu, 9 May 2019 16:48:57 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Cornelia Huck (coh...@redhat.com) wrote: > > > > On Tue, 7 May 2019 15:18:26 -0600 > > > >

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Yan Zhao
On Thu, May 09, 2019 at 11:24:49PM +0800, Cornelia Huck wrote: > On Wed, 8 May 2019 07:57:05 -0400 > Yan Zhao wrote: > > > On Tue, May 07, 2019 at 05:19:54PM +0800, Cornelia Huck wrote: > > > On Sun, 5 May 2019 21:49:04 -0400 > > > Yan Zhao wrote: > > > > > > > version attribute is used to

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Dr. David Alan Gilbert
* Cornelia Huck (coh...@redhat.com) wrote: > On Thu, 9 May 2019 16:48:57 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Cornelia Huck (coh...@redhat.com) wrote: > > > On Tue, 7 May 2019 15:18:26 -0600 > > > Alex Williamson wrote: > > > > > > > On Sun, 5 May 2019 21:49:04 -0400 > > > > Yan

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Cornelia Huck
On Thu, 9 May 2019 16:48:57 +0100 "Dr. David Alan Gilbert" wrote: > * Cornelia Huck (coh...@redhat.com) wrote: > > On Tue, 7 May 2019 15:18:26 -0600 > > Alex Williamson wrote: > > > > > On Sun, 5 May 2019 21:49:04 -0400 > > > Yan Zhao wrote: > > > > > > + Errno: > > > > + If vendor

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Dr. David Alan Gilbert
* Cornelia Huck (coh...@redhat.com) wrote: > On Tue, 7 May 2019 15:18:26 -0600 > Alex Williamson wrote: > > > On Sun, 5 May 2019 21:49:04 -0400 > > Yan Zhao wrote: > > > > + Errno: > > > + If vendor driver wants to claim a mdev device incompatible to all > > > other mdev > > > + devices,

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Cornelia Huck
On Tue, 7 May 2019 15:18:26 -0600 Alex Williamson wrote: > On Sun, 5 May 2019 21:49:04 -0400 > Yan Zhao wrote: > > + Errno: > > + If vendor driver wants to claim a mdev device incompatible to all other > > mdev > > + devices, it should not register version attribute for this mdev device.

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Cornelia Huck
On Wed, 8 May 2019 07:57:05 -0400 Yan Zhao wrote: > On Tue, May 07, 2019 at 05:19:54PM +0800, Cornelia Huck wrote: > > On Sun, 5 May 2019 21:49:04 -0400 > > Yan Zhao wrote: > > > > > version attribute is used to check two mdev devices' compatibility. > > > > > > The key point of this

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Yan Zhao
On Wed, May 08, 2019 at 11:27:47PM +0800, Boris Fiuczynski wrote: > On 5/8/19 11:22 PM, Alex Williamson wrote: > >>> I thought there was a request to make this more specific to migration > >>> by renaming it to something like migration_version. Also, as an > >>> > >> so this attribute may not

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Boris Fiuczynski
On 5/8/19 11:22 PM, Alex Williamson wrote: I thought there was a request to make this more specific to migration by renaming it to something like migration_version. Also, as an so this attribute may not only include a mdev device's parent device info and mdev type, but also include numeric

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-08 Thread Yan Zhao
On Thu, May 09, 2019 at 11:38:34AM +0800, Alex Williamson wrote: > On Wed, 8 May 2019 23:10:55 -0400 > Yan Zhao wrote: > > > On Thu, May 09, 2019 at 05:22:42AM +0800, Alex Williamson wrote: > > > On Wed, 8 May 2019 07:27:40 -0400 > > > Yan Zhao wrote: > > > > > > > On Wed, May 08, 2019 at

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-08 Thread Alex Williamson
On Wed, 8 May 2019 23:10:55 -0400 Yan Zhao wrote: > On Thu, May 09, 2019 at 05:22:42AM +0800, Alex Williamson wrote: > > On Wed, 8 May 2019 07:27:40 -0400 > > Yan Zhao wrote: > > > > > On Wed, May 08, 2019 at 05:18:26AM +0800, Alex Williamson wrote: > > > > On Sun, 5 May 2019 21:49:04

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-08 Thread Yan Zhao
On Thu, May 09, 2019 at 05:22:42AM +0800, Alex Williamson wrote: > On Wed, 8 May 2019 07:27:40 -0400 > Yan Zhao wrote: > > > On Wed, May 08, 2019 at 05:18:26AM +0800, Alex Williamson wrote: > > > On Sun, 5 May 2019 21:49:04 -0400 > > > Yan Zhao wrote: > > > > > > > version attribute is used

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-08 Thread Alex Williamson
On Wed, 8 May 2019 07:27:40 -0400 Yan Zhao wrote: > On Wed, May 08, 2019 at 05:18:26AM +0800, Alex Williamson wrote: > > On Sun, 5 May 2019 21:49:04 -0400 > > Yan Zhao wrote: > > > > > version attribute is used to check two mdev devices' compatibility. > > > > > > The key point of this

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-08 Thread Yan Zhao
On Tue, May 07, 2019 at 05:19:54PM +0800, Cornelia Huck wrote: > On Sun, 5 May 2019 21:49:04 -0400 > Yan Zhao wrote: > > > version attribute is used to check two mdev devices' compatibility. > > > > The key point of this version attribute is that it's rw. > > User space has no need to

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-08 Thread Yan Zhao
On Wed, May 08, 2019 at 05:18:26AM +0800, Alex Williamson wrote: > On Sun, 5 May 2019 21:49:04 -0400 > Yan Zhao wrote: > > > version attribute is used to check two mdev devices' compatibility. > > > > The key point of this version attribute is that it's rw. > > User space has no need to

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-07 Thread Alex Williamson
On Sun, 5 May 2019 21:49:04 -0400 Yan Zhao wrote: > version attribute is used to check two mdev devices' compatibility. > > The key point of this version attribute is that it's rw. > User space has no need to understand internal of device version and no > need to compare versions by itself. >

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-07 Thread Cornelia Huck
On Sun, 5 May 2019 21:49:04 -0400 Yan Zhao wrote: > version attribute is used to check two mdev devices' compatibility. > > The key point of this version attribute is that it's rw. > User space has no need to understand internal of device version and no > need to compare versions by itself. >

[libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-05 Thread Yan Zhao
version attribute is used to check two mdev devices' compatibility. The key point of this version attribute is that it's rw. User space has no need to understand internal of device version and no need to compare versions by itself. Compared to reading version strings from both two mdev devices