Re: [PATCH v2 1/3] iotests: Specify explicit backing format where sensible

2020-03-05 Thread Eric Blake
On 2/27/20 7:08 AM, Eric Blake wrote: The change in libvirt to reject images without explicit backing format has pointed out that a number of tools have been far too reliant on probing in the past.  It's time to set a better example in our own iotests of properly setting this parameter. iotest

Re: [PATCH v2 1/3] iotests: Specify explicit backing format where sensible

2020-02-27 Thread Eric Blake
On 2/27/20 3:19 AM, Ján Tomko wrote: On a Wednesday in 2020, Eric Blake wrote: There are many existing qcow2 images that specify a backing file but no format.  This has been the source of CVEs in the past, but has become more prominent of a problem now that libvirt has switched to -blockdev. 

Re: [PATCH v2 1/3] iotests: Specify explicit backing format where sensible

2020-02-27 Thread Eric Blake
On 2/27/20 1:20 AM, Peter Krempa wrote: On Wed, Feb 26, 2020 at 20:39:26 -0600, Eric Blake wrote: There are many existing qcow2 images that specify a backing file but no format. This has been the source of CVEs in the past, but has become more prominent of a problem now that libvirt has

Re: [PATCH v2 1/3] iotests: Specify explicit backing format where sensible

2020-02-27 Thread Ján Tomko
On a Wednesday in 2020, Eric Blake wrote: There are many existing qcow2 images that specify a backing file but no format. This has been the source of CVEs in the past, but has become more prominent of a problem now that libvirt has switched to -blockdev. With older -drive, at least the probing

Re: [PATCH v2 1/3] iotests: Specify explicit backing format where sensible

2020-02-27 Thread Ján Tomko
On a Thursday in 2020, Peter Krempa wrote: On Wed, Feb 26, 2020 at 20:39:26 -0600, Eric Blake wrote: There are many existing qcow2 images that specify a backing file but no format. This has been the source of CVEs in the past, but has become more prominent of a problem now that libvirt has

Re: [PATCH v2 1/3] iotests: Specify explicit backing format where sensible

2020-02-26 Thread Peter Krempa
On Wed, Feb 26, 2020 at 20:39:26 -0600, Eric Blake wrote: > There are many existing qcow2 images that specify a backing file but > no format. This has been the source of CVEs in the past, but has > become more prominent of a problem now that libvirt has switched to > -blockdev. With older