Re: [PATCH v2 1/4] qemu: avoid launching non-x86 guests with APIC-EOI setting

2020-03-25 Thread Andrea Bolognani
On Tue, 2020-03-24 at 14:33 -0300, Daniel Henrique Barboza wrote: [...] > Suggested-by: Andrea Bolognani Merely providing review feedback is not usually considered enough to get Suggested-by credits, so I'll drop this. > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1236440 The consensus

[PATCH v2 1/4] qemu: avoid launching non-x86 guests with APIC-EOI setting

2020-03-24 Thread Daniel Henrique Barboza
The "" feature, although it's available only for x86 guests, can be declared in the domain XML of other archs without errors. But setting its 'eoi' attribute will break QEMU. For "", in a ppc64 guest: qemu-kvm: Expected key=value format, found +kvm_pv_eoi A similar error happens with eoi='off'.