Re: [PATCH v2 16/19] Refactoring virDomainGraphicsDefParseXMLSpice() to use XPath

2022-03-25 Thread Andrea Bolognani
On Thu, Mar 24, 2022 at 07:16:28PM +0100, Michal Prívozník wrote: > On 3/24/22 18:02, Andrea Bolognani wrote: > > but I can't help > > wondering if there are other cases where switching to > > virXPathString() in the way seen here might have introduced undesired > > changes in behavior. > > > >

Re: [PATCH v2 16/19] Refactoring virDomainGraphicsDefParseXMLSpice() to use XPath

2022-03-24 Thread Michal Prívozník
On 3/24/22 18:02, Andrea Bolognani wrote: > > but I can't help > wondering if there are other cases where switching to > virXPathString() in the way seen here might have introduced undesired > changes in behavior. > > Thoughts? > Unless you want to audit every virXPath*() call with its

Re: [PATCH v2 16/19] Refactoring virDomainGraphicsDefParseXMLSpice() to use XPath

2022-03-24 Thread Andrea Bolognani
On Tue, May 04, 2021 at 01:40:10PM +0200, Kristina Hanicova wrote: > -} else if (virXMLNodeNameEqual(cur, "playback")) { > -int compressionVal; > -g_autofree char *compression = virXMLPropString(cur, > "compression"); > - > -if

[PATCH v2 16/19] Refactoring virDomainGraphicsDefParseXMLSpice() to use XPath

2021-05-04 Thread Kristina Hanicova
Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 303 - 1 file changed, 114 insertions(+), 189 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2511778b15..206816d76f 100644 --- a/src/conf/domain_conf.c +++