Re: [PATCH v2 2/2] Use virProcessGetStat

2021-11-23 Thread Martin Kletzander
On Mon, Nov 22, 2021 at 09:59:07AM +, Daniel P. Berrangé wrote: On Mon, Nov 22, 2021 at 10:34:38AM +0100, Martin Kletzander wrote: On Mon, Nov 22, 2021 at 09:18:41AM +, Daniel P. Berrangé wrote: > On Sun, Nov 21, 2021 at 12:04:26AM +0100, Martin Kletzander wrote: > > This eliminates one

Re: [PATCH v2 2/2] Use virProcessGetStat

2021-11-22 Thread Daniel P . Berrangé
On Mon, Nov 22, 2021 at 10:34:38AM +0100, Martin Kletzander wrote: > On Mon, Nov 22, 2021 at 09:18:41AM +, Daniel P. Berrangé wrote: > > On Sun, Nov 21, 2021 at 12:04:26AM +0100, Martin Kletzander wrote: > > > This eliminates one incorrect parsing implementation. > > > > Please explain what wa

Re: [PATCH v2 2/2] Use virProcessGetStat

2021-11-22 Thread Martin Kletzander
On Mon, Nov 22, 2021 at 09:18:41AM +, Daniel P. Berrangé wrote: On Sun, Nov 21, 2021 at 12:04:26AM +0100, Martin Kletzander wrote: This eliminates one incorrect parsing implementation. Please explain what was being done wrongly / what was the effect of the bug ? One of the implementatio

Re: [PATCH v2 2/2] Use virProcessGetStat

2021-11-22 Thread Daniel P . Berrangé
On Sun, Nov 21, 2021 at 12:04:26AM +0100, Martin Kletzander wrote: > This eliminates one incorrect parsing implementation. Please explain what was being done wrongly / what was the effect of the bug ? > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_driver.c | 33 ++--

[PATCH v2 2/2] Use virProcessGetStat

2021-11-20 Thread Martin Kletzander
This eliminates one incorrect parsing implementation. Signed-off-by: Martin Kletzander --- src/qemu/qemu_driver.c | 33 ++--- src/util/virprocess.c | 48 ++ 2 files changed, 12 insertions(+), 69 deletions(-) diff --git a/src/qemu/