On 1/25/21 1:24 PM, Moshe Levi wrote:
Hi Laine,
Sorry for the mistake in the split of the commit, and thank for fix it 😊.
I review you change and it is better.
I tested it on Mellanox card with kernel 5.9 and it work good with SR-IOV
legacy and SR-IOV switchdev.
You have my LGTM for it.
Okay.
; From: Laine Stump
> Sent: Monday, January 25, 2021 7:23 AM
> To: libvir-list@redhat.com
> Cc: Moshe Levi ; Adrian Chiris
> Subject: Re: [PATCH v2 2/2] util: Add phys_port_name support on
> virPCIGetNetName
>
> External email: Use caution opening links or attachments
>
>
On 1/21/21 7:15 AM, Moshe Levi wrote:
From: Dmytro Linkin
Current virPCIGetNetName() logic is to get net device name by checking
it's phys_port_id, if caller provide it, or by it's index (eg, by it's
position at sysfs net directory). This approach worked fine up until
linux kernel version 5.8,
From: Dmytro Linkin
Current virPCIGetNetName() logic is to get net device name by checking
it's phys_port_id, if caller provide it, or by it's index (eg, by it's
position at sysfs net directory). This approach worked fine up until
linux kernel version 5.8, where NVIDIA Mellanox driver implemented