Re: [PATCH v2 2/3] virprocess: Make virProcessGetStatInfo() fail if unable to parse data

2023-01-23 Thread Michal Prívozník
On 1/19/23 15:15, Martin Kletzander wrote: > On Wed, Jan 18, 2023 at 10:58:18AM +0100, Michal Privoznik wrote: >> Yeah, we've already seen this commit (v8.0.0-rc2~4) and also its >> revert (v8.1.0-rc1~345). While the original idea was sound, the >> implementation was less so and it changed

Re: [PATCH v2 2/3] virprocess: Make virProcessGetStatInfo() fail if unable to parse data

2023-01-19 Thread Martin Kletzander
On Wed, Jan 18, 2023 at 10:58:18AM +0100, Michal Privoznik wrote: Yeah, we've already seen this commit (v8.0.0-rc2~4) and also its revert (v8.1.0-rc1~345). While the original idea was sound, the implementation was less so and it changed behaviour of some public APIs (e.g. whilst getting stats

[PATCH v2 2/3] virprocess: Make virProcessGetStatInfo() fail if unable to parse data

2023-01-18 Thread Michal Privoznik
Yeah, we've already seen this commit (v8.0.0-rc2~4) and also its revert (v8.1.0-rc1~345). While the original idea was sound, the implementation was less so and it changed behaviour of some public APIs (e.g. whilst getting stats for a running guest was best effort it started to return errors).