Re: [PATCH v2 2/4] virpidfile: Refactor virPidFileReadPathIfAlive

2022-02-02 Thread Vasily Ulyanov
Hi Michal, I think it probably makes sense then to just do the lock checking specifically for tpm and gpu cases and not to change the behavior of virPidFileReadPathIfAlive (since it is used in several places in the project). Thank you for the review. I will also follow your other suggestions and

Re: [PATCH v2 2/4] virpidfile: Refactor virPidFileReadPathIfAlive

2022-02-02 Thread Michal Prívozník
On 1/13/22 13:42, Vasiliy Ulyanov wrote: > If the binary path is not provided check that the pid file is locked by > the owner process. > > Signed-off-by: Vasiliy Ulyanov > --- > src/util/virpidfile.c | 20 > 1 file changed, 20 insertions(+) > > diff --git

[PATCH v2 2/4] virpidfile: Refactor virPidFileReadPathIfAlive

2022-01-13 Thread Vasiliy Ulyanov
If the binary path is not provided check that the pid file is locked by the owner process. Signed-off-by: Vasiliy Ulyanov --- src/util/virpidfile.c | 20 1 file changed, 20 insertions(+) diff --git a/src/util/virpidfile.c b/src/util/virpidfile.c index