Re: [PATCH v2 2/7] vircommand: Document virCommandSetSendBuffer() behaviour wrt daemonize

2022-03-23 Thread Michal Prívozník
On 3/23/22 08:48, Marc-André Lureau wrote: > Hi > > On Tue, Mar 22, 2022 at 8:02 PM Michal Privoznik > wrote: > > When virCommandSetSendBuffer() is used over a virCommand that is > (or will be) daemonized, then VIR_EXEC_ASYNC_IO the command must > have

Re: [PATCH v2 2/7] vircommand: Document virCommandSetSendBuffer() behaviour wrt daemonize

2022-03-23 Thread Marc-André Lureau
Hi On Tue, Mar 22, 2022 at 8:02 PM Michal Privoznik wrote: > When virCommandSetSendBuffer() is used over a virCommand that is > (or will be) daemonized, then VIR_EXEC_ASYNC_IO the command must > have VIR_EXEC_ASYNC_IO flag set no later than at > virCommandRunAsync() phase so that the thread

[PATCH v2 2/7] vircommand: Document virCommandSetSendBuffer() behaviour wrt daemonize

2022-03-22 Thread Michal Privoznik
When virCommandSetSendBuffer() is used over a virCommand that is (or will be) daemonized, then VIR_EXEC_ASYNC_IO the command must have VIR_EXEC_ASYNC_IO flag set no later than at virCommandRunAsync() phase so that the thread that's doing IO is spawned and thus buffers can be sent to the process.