Re: [PATCH v3 0/3] qemu_tpm: Get swtpm pid without binary validation

2022-02-04 Thread Michal Prívozník
On 2/3/22 18:56, Vasily Ulyanov wrote: > Hi Michal, > > On 03/02/2022 18:09, Michal Prívozník wrote: >> >> Apart from patch 2/3 this looks good. So here's what we are going to do. >> I've uploaded fixup commits onto my gitlab: >> >>

Re: [PATCH v3 0/3] qemu_tpm: Get swtpm pid without binary validation

2022-02-03 Thread Vasily Ulyanov
Hi Michal, On 03/02/2022 18:09, Michal Prívozník wrote: > > Apart from patch 2/3 this looks good. So here's what we are going to do. > I've uploaded fixup commits onto my gitlab: > > https://gitlab.com/MichalPrivoznik/libvirt/-/commits/virpidfile/ > > Please take a look and if you agree I

Re: [PATCH v3 0/3] qemu_tpm: Get swtpm pid without binary validation

2022-02-03 Thread Michal Prívozník
On 2/2/22 17:28, Vasiliy Ulyanov wrote: > [v1] > https://listman.redhat.com/archives/libvir-list/2022-January/msg8.html > [v2] > https://listman.redhat.com/archives/libvir-list/2022-January/msg00582.html > > As suggesed in the review comments: > - dropped virFileGetLockOwner; > - simplified

[PATCH v3 0/3] qemu_tpm: Get swtpm pid without binary validation

2022-02-02 Thread Vasiliy Ulyanov
[v1] https://listman.redhat.com/archives/libvir-list/2022-January/msg8.html [v2] https://listman.redhat.com/archives/libvir-list/2022-January/msg00582.html As suggesed in the review comments: - dropped virFileGetLockOwner; - simplified lock validation by using VIR_AUTOCLOSE and just trying to