Re: [PATCH v3 01/14] domain_conf: move boot timeouts check to domain_validate.c

2020-12-09 Thread Daniel Henrique Barboza
On 12/9/20 7:52 AM, Daniel P. Berrangé wrote: On Wed, Dec 09, 2020 at 07:35:09AM -0300, Daniel Henrique Barboza wrote: On 12/9/20 5:13 AM, Michal Privoznik wrote: On 12/8/20 11:20 PM, Daniel Henrique Barboza wrote: This patch creates a new function, virDomainDefBootValidate(), to host

Re: [PATCH v3 01/14] domain_conf: move boot timeouts check to domain_validate.c

2020-12-09 Thread Daniel P . Berrangé
On Wed, Dec 09, 2020 at 07:35:09AM -0300, Daniel Henrique Barboza wrote: > > > On 12/9/20 5:13 AM, Michal Privoznik wrote: > > On 12/8/20 11:20 PM, Daniel Henrique Barboza wrote: > > > This patch creates a new function, virDomainDefBootValidate(), to host > > > the validation of boot menu

Re: [PATCH v3 01/14] domain_conf: move boot timeouts check to domain_validate.c

2020-12-09 Thread Daniel Henrique Barboza
On 12/9/20 5:13 AM, Michal Privoznik wrote: On 12/8/20 11:20 PM, Daniel Henrique Barboza wrote: This patch creates a new function, virDomainDefBootValidate(), to host the validation of boot menu timeout and rebootTimeout outside of parse time. The checks in virDomainDefParseBootXML() were

Re: [PATCH v3 01/14] domain_conf: move boot timeouts check to domain_validate.c

2020-12-09 Thread Michal Privoznik
On 12/8/20 11:20 PM, Daniel Henrique Barboza wrote: This patch creates a new function, virDomainDefBootValidate(), to host the validation of boot menu timeout and rebootTimeout outside of parse time. The checks in virDomainDefParseBootXML() were changed to throw VIR_ERR_XML_ERROR in case of

[PATCH v3 01/14] domain_conf: move boot timeouts check to domain_validate.c

2020-12-08 Thread Daniel Henrique Barboza
This patch creates a new function, virDomainDefBootValidate(), to host the validation of boot menu timeout and rebootTimeout outside of parse time. The checks in virDomainDefParseBootXML() were changed to throw VIR_ERR_XML_ERROR in case of parse error of those values. In an attempt to alleviate