Re: [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global

2023-04-20 Thread Philippe Mathieu-Daudé
On 17/4/23 18:40, Peter Maydell wrote: The only place left that looks at the old 'singlestep' global variable is the TCG curr_cflags() function. Replace the old global with a new 'one_insn_per_tb' which is defined in tcg-all.c and declared in accel/tcg/internal.h. This keeps it restricted to

Re: [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global

2023-04-18 Thread Peter Maydell
On Tue, 18 Apr 2023 at 09:05, Richard Henderson wrote: > > On 4/17/23 18:40, Peter Maydell wrote: > > @@ -219,8 +221,8 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool > > value, Error **errp) > > { > > TCGState *s = TCG_STATE(obj); > > s->one_insn_per_tb = value; > > -

Re: [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global

2023-04-18 Thread Richard Henderson
On 4/17/23 18:40, Peter Maydell wrote: The only place left that looks at the old 'singlestep' global variable is the TCG curr_cflags() function. Replace the old global with a new 'one_insn_per_tb' which is defined in tcg-all.c and declared in accel/tcg/internal.h. This keeps it restricted to

Re: [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global

2023-04-18 Thread Richard Henderson
On 4/17/23 18:40, Peter Maydell wrote: @@ -219,8 +221,8 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool value, Error **errp) { TCGState *s = TCG_STATE(obj); s->one_insn_per_tb = value; -/* For the moment, set the global also: this changes the behaviour */ -

[PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global

2023-04-17 Thread Peter Maydell
The only place left that looks at the old 'singlestep' global variable is the TCG curr_cflags() function. Replace the old global with a new 'one_insn_per_tb' which is defined in tcg-all.c and declared in accel/tcg/internal.h. This keeps it restricted to the TCG code, unlike 'singlestep' which