Re: [PATCH v3 26/30] qemu-img: Use user_creatable_process_cmdline() for --object

2021-03-15 Thread Kevin Wolf
Am 15.03.2021 um 15:15 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 13.03.2021 um 13:30 hat Markus Armbruster geschrieben: > >> Paolo Bonzini writes: > >> > >> > On 13/03/21 08:40, Markus Armbruster wrote: > >> >>> +if (!user_creatable_add_from_str(optarg,

Re: [PATCH v3 26/30] qemu-img: Use user_creatable_process_cmdline() for --object

2021-03-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 13.03.2021 um 13:30 hat Markus Armbruster geschrieben: >> Paolo Bonzini writes: >> >> > On 13/03/21 08:40, Markus Armbruster wrote: >> >>> +if (!user_creatable_add_from_str(optarg, _err)) { >> >>> +if (local_err) { >> >>> +

Re: [PATCH v3 26/30] qemu-img: Use user_creatable_process_cmdline() for --object

2021-03-15 Thread Kevin Wolf
Am 13.03.2021 um 13:30 hat Markus Armbruster geschrieben: > Paolo Bonzini writes: > > > On 13/03/21 08:40, Markus Armbruster wrote: > >>> +if (!user_creatable_add_from_str(optarg, _err)) { > >>> +if (local_err) { > >>> +

Re: [PATCH v3 26/30] qemu-img: Use user_creatable_process_cmdline() for --object

2021-03-13 Thread Markus Armbruster
Paolo Bonzini writes: > On 13/03/21 08:40, Markus Armbruster wrote: >>> +if (!user_creatable_add_from_str(optarg, _err)) { >>> +if (local_err) { >>> +error_report_err(local_err); >>> +exit(2); >>> +

Re: [PATCH v3 26/30] qemu-img: Use user_creatable_process_cmdline() for --object

2021-03-12 Thread Paolo Bonzini
On 13/03/21 08:40, Markus Armbruster wrote: +if (!user_creatable_add_from_str(optarg, _err)) { +if (local_err) { +error_report_err(local_err); +exit(2); +} else { +/*

Re: [PATCH v3 26/30] qemu-img: Use user_creatable_process_cmdline() for --object

2021-03-12 Thread Markus Armbruster
Kevin Wolf writes: > This switches qemu-img from a QemuOpts-based parser for --object to > user_creatable_process_cmdline() which uses a keyval parser and enforces > the QAPI schema. > > Apart from being a cleanup, this makes non-scalar properties accessible. > > Signed-off-by: Kevin Wolf >

Re: [PATCH v3 26/30] qemu-img: Use user_creatable_process_cmdline() for --object

2021-03-08 Thread Eric Blake
On 3/8/21 10:54 AM, Kevin Wolf wrote: > This switches qemu-img from a QemuOpts-based parser for --object to > user_creatable_process_cmdline() which uses a keyval parser and enforces > the QAPI schema. > > Apart from being a cleanup, this makes non-scalar properties accessible. > >

[PATCH v3 26/30] qemu-img: Use user_creatable_process_cmdline() for --object

2021-03-08 Thread Kevin Wolf
This switches qemu-img from a QemuOpts-based parser for --object to user_creatable_process_cmdline() which uses a keyval parser and enforces the QAPI schema. Apart from being a cleanup, this makes non-scalar properties accessible. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa ---