Re: [PATCH v3 27/30] hmp: QAPIfy object_add

2021-03-15 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 15.03.2021 um 10:39 hat Markus Armbruster geschrieben: > > Paolo Bonzini writes: > > > > > On 13/03/21 14:28, Markus Armbruster wrote: > > >> Kevin Wolf writes: > > >> > > >>> This switches the HMP command object_add from a QemuOpts-based parser to >

Re: [PATCH v3 27/30] hmp: QAPIfy object_add

2021-03-15 Thread Paolo Bonzini
On 15/03/21 12:38, Dr. David Alan Gilbert wrote: * Kevin Wolf (kw...@redhat.com) wrote: Am 15.03.2021 um 10:39 hat Markus Armbruster geschrieben: Paolo Bonzini writes: On 13/03/21 14:28, Markus Armbruster wrote: Kevin Wolf writes: This switches the HMP command object_add from a

Re: [PATCH v3 27/30] hmp: QAPIfy object_add

2021-03-15 Thread Kevin Wolf
Am 15.03.2021 um 10:39 hat Markus Armbruster geschrieben: > Paolo Bonzini writes: > > > On 13/03/21 14:28, Markus Armbruster wrote: > >> Kevin Wolf writes: > >> > >>> This switches the HMP command object_add from a QemuOpts-based parser to > >>> user_creatable_add_from_str() which uses a

Re: [PATCH v3 27/30] hmp: QAPIfy object_add

2021-03-15 Thread Markus Armbruster
Paolo Bonzini writes: > On 13/03/21 14:28, Markus Armbruster wrote: >> Kevin Wolf writes: >> >>> This switches the HMP command object_add from a QemuOpts-based parser to >>> user_creatable_add_from_str() which uses a keyval parser and enforces >>> the QAPI schema. >>> >>> Apart from being a

Re: [PATCH v3 27/30] hmp: QAPIfy object_add

2021-03-13 Thread Paolo Bonzini
On 13/03/21 14:28, Markus Armbruster wrote: Kevin Wolf writes: This switches the HMP command object_add from a QemuOpts-based parser to user_creatable_add_from_str() which uses a keyval parser and enforces the QAPI schema. Apart from being a cleanup, this makes non-scalar properties and help

Re: [PATCH v3 27/30] hmp: QAPIfy object_add

2021-03-13 Thread Markus Armbruster
Kevin Wolf writes: > This switches the HMP command object_add from a QemuOpts-based parser to > user_creatable_add_from_str() which uses a keyval parser and enforces > the QAPI schema. > > Apart from being a cleanup, this makes non-scalar properties and help > accessible. In order for help to be

[PATCH v3 27/30] hmp: QAPIfy object_add

2021-03-08 Thread Kevin Wolf
This switches the HMP command object_add from a QemuOpts-based parser to user_creatable_add_from_str() which uses a keyval parser and enforces the QAPI schema. Apart from being a cleanup, this makes non-scalar properties and help accessible. In order for help to be printed to the monitor instead