Re: [PATCH v4] report error when virProcessGetStatInfo() is unable to parse data

2022-01-12 Thread Ani Sinha
On Wed, Jan 12, 2022 at 6:49 PM Michal Prívozník wrote: > On 1/11/22 19:13, Ani Sinha wrote: > > Currently virProcessGetStatInfo() always returns success and only logs > error > > when it is unable to parse the data. Make this function actually report > the > > error and return a negative value

Re: [PATCH v4] report error when virProcessGetStatInfo() is unable to parse data

2022-01-12 Thread Michal Prívozník
On 1/11/22 19:13, Ani Sinha wrote: > Currently virProcessGetStatInfo() always returns success and only logs error > when it is unable to parse the data. Make this function actually report the > error and return a negative value in this error scenario. > > Fix the callers so that they do not

Re: [PATCH v4] report error when virProcessGetStatInfo() is unable to parse data

2022-01-12 Thread Michal Prívozník
On 1/11/22 19:20, Ani Sinha wrote: > I just realized after sending this patch that I made the change in the > Linux version of the function. It may not be applicable for FreeBSD .  > In any case I simply don’t understand if errors on the logs is a > problem. If it is maybe we need a FreeBSD

Re: [PATCH v4] report error when virProcessGetStatInfo() is unable to parse data

2022-01-11 Thread Ani Sinha
I just realized after sending this patch that I made the change in the Linux version of the function. It may not be applicable for FreeBSD . In any case I simply don’t understand if errors on the logs is a problem. If it is maybe we need a FreeBSD version of this function as well not just a larger

[PATCH v4] report error when virProcessGetStatInfo() is unable to parse data

2022-01-11 Thread Ani Sinha
Currently virProcessGetStatInfo() always returns success and only logs error when it is unable to parse the data. Make this function actually report the error and return a negative value in this error scenario. Fix the callers so that they do not override the error generated. Also fix non-linux