Re: [PATCH v4 1/7] migration/dirtyrate: Introduce virDomainDirtyRateInfo structure

2020-11-16 Thread Hao Wang
Do you mean embed this api into domstats like "virsh domstats --dirtyrate"? It's indeed a good idea in consideration of extensibility. I will try that in my next version, however, I have no idea about where to place my secondary options (--second, --calculate and --query). Any suggestion? PS:

Re: [PATCH v4 1/7] migration/dirtyrate: Introduce virDomainDirtyRateInfo structure

2020-11-11 Thread Peter Krempa
On Tue, Nov 10, 2020 at 21:12:33 +0100, Michal Privoznik wrote: > On 11/7/20 10:41 AM, Hao Wang wrote: > > Introduce virDomainDirtyRateInfo structure used for domain's memory dirty > > rate query. > > > > Signed-off-by: Hao Wang > > Reviewed-by: Chuan Zheng > > --- > >

Re: [PATCH v4 1/7] migration/dirtyrate: Introduce virDomainDirtyRateInfo structure

2020-11-10 Thread Michal Privoznik
On 11/7/20 10:41 AM, Hao Wang wrote: Introduce virDomainDirtyRateInfo structure used for domain's memory dirty rate query. Signed-off-by: Hao Wang Reviewed-by: Chuan Zheng --- include/libvirt/libvirt-domain.h | 24 1 file changed, 24 insertions(+) diff --git

[PATCH v4 1/7] migration/dirtyrate: Introduce virDomainDirtyRateInfo structure

2020-11-07 Thread Hao Wang
Introduce virDomainDirtyRateInfo structure used for domain's memory dirty rate query. Signed-off-by: Hao Wang Reviewed-by: Chuan Zheng --- include/libvirt/libvirt-domain.h | 24 1 file changed, 24 insertions(+) diff --git a/include/libvirt/libvirt-domain.h