Re: [PATCH v4 3/4] lxc: remove domain definition from lxc network struct

2020-02-03 Thread Michal Privoznik
On 2/3/20 3:34 PM, Julio Faracco wrote: I agree, Michal. I reviewed the logic and it is impossible to get a NULL pointer using both approaches. Thanks! Alright, I've removed the check and pushed. Reviewed-by: Michal Privoznik Michal

Re: [PATCH v4 3/4] lxc: remove domain definition from lxc network struct

2020-02-03 Thread Julio Faracco
I agree, Michal. I reviewed the logic and it is impossible to get a NULL pointer using both approaches. Thanks! -- Julio Cesar Faracco Em seg., 3 de fev. de 2020 às 07:06, Michal Privoznik escreveu: > > On 2/3/20 2:28 AM, Julio Faracco wrote: > > Domain definition is useless now inside network

Re: [PATCH v4 3/4] lxc: remove domain definition from lxc network struct

2020-02-03 Thread Michal Privoznik
On 2/3/20 2:28 AM, Julio Faracco wrote: Domain definition is useless now inside network structure. This pointer was required because new network definition was being added each time that a new network type appeared. So, this should be processed into old function `lxcNetworkParseDataType()`. Now,

[PATCH v4 3/4] lxc: remove domain definition from lxc network struct

2020-02-02 Thread Julio Faracco
Domain definition is useless now inside network structure. This pointer was required because new network definition was being added each time that a new network type appeared. So, this should be processed into old function `lxcNetworkParseDataType()`. Now, as it was moved to an array, it can be