Re: [PATCH v5 1/9] qemu: Refactor dirty page rate calculation status implementation

2022-02-21 Thread Daniel P . Berrangé
On Thu, Feb 17, 2022 at 05:19:32PM +0100, Michal Prívozník wrote: > On 2/16/22 01:28, huang...@chinatelecom.cn wrote: > > From: Hyman Huang(黄勇) > > > > For any virTypedParameter API normal practice is to use a string > > to expose the data, not the rather enum integer value. > > > > So let's dro

Re: [PATCH v5 1/9] qemu: Refactor dirty page rate calculation status implementation

2022-02-17 Thread Hyman Huang
在 2022/2/18 0:19, Michal Prívozník 写道: On 2/16/22 01:28, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) For any virTypedParameter API normal practice is to use a string to expose the data, not the rather enum integer value. So let's drop the virDomainDirtyRateStatus in public header

Re: [PATCH v5 1/9] qemu: Refactor dirty page rate calculation status implementation

2022-02-17 Thread Michal Prívozník
On 2/16/22 01:28, huang...@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > For any virTypedParameter API normal practice is to use a string > to expose the data, not the rather enum integer value. > > So let's drop the virDomainDirtyRateStatus in public header file > and introduce internal en

[PATCH v5 1/9] qemu: Refactor dirty page rate calculation status implementation

2022-02-15 Thread huangy81
From: Hyman Huang(黄勇) For any virTypedParameter API normal practice is to use a string to expose the data, not the rather enum integer value. So let's drop the virDomainDirtyRateStatus in public header file and introduce internal enum def qemuMonitorDirtyRateStatus to describe the dirty page rat