Re: [PATCH v6 3/4] remove sysconfig files

2022-01-11 Thread Andrea Bolognani
On Tue, Jan 11, 2022 at 10:10:30AM +, Daniel P. Berrangé wrote: > On Tue, Jan 11, 2022 at 10:05:41AM +, Andrea Bolognani wrote: > > But, what you're saying is that there are still valid use cases > > for setting those in the service file, and we can't quite get rid of > > them yet - or

Re: [PATCH v6 3/4] remove sysconfig files

2022-01-11 Thread Daniel P . Berrangé
On Tue, Jan 11, 2022 at 10:05:41AM +, Andrea Bolognani wrote: > On Tue, Jan 11, 2022 at 09:56:30AM +, Daniel P. Berrangé wrote: > > On Tue, Jan 11, 2022 at 09:51:05AM +, Andrea Bolognani wrote: > > > On Tue, Jan 11, 2022 at 10:21:32AM +0100, Olaf Hering wrote: > > > > Mon, 3 Jan 2022

Re: [PATCH v6 3/4] remove sysconfig files

2022-01-11 Thread Andrea Bolognani
On Tue, Jan 11, 2022 at 09:56:30AM +, Daniel P. Berrangé wrote: > On Tue, Jan 11, 2022 at 09:51:05AM +, Andrea Bolognani wrote: > > On Tue, Jan 11, 2022 at 10:21:32AM +0100, Olaf Hering wrote: > > > Mon, 3 Jan 2022 03:18:11 -0800 Andrea Bolognani : > > > > The fact that we still

Re: [PATCH v6 3/4] remove sysconfig files

2022-01-11 Thread Daniel P . Berrangé
On Tue, Jan 11, 2022 at 09:51:05AM +, Andrea Bolognani wrote: > On Tue, Jan 11, 2022 at 10:21:32AM +0100, Olaf Hering wrote: > > Mon, 3 Jan 2022 03:18:11 -0800 Andrea Bolognani : > > > > > The fact that we still QEMU_AUDIO_DRV and SDL_AUDIODRIVER in the > > > service file even after your

Re: [PATCH v6 3/4] remove sysconfig files

2022-01-11 Thread Andrea Bolognani
On Tue, Jan 11, 2022 at 10:21:32AM +0100, Olaf Hering wrote: > Mon, 3 Jan 2022 03:18:11 -0800 Andrea Bolognani : > > > The fact that we still QEMU_AUDIO_DRV and SDL_AUDIODRIVER in the > > service file even after your changes goes against this principle. > > So what should be done about these? > >

Re: [PATCH v6 3/4] remove sysconfig files

2022-01-11 Thread Olaf Hering
Mon, 3 Jan 2022 03:18:11 -0800 Andrea Bolognani : > The fact that we still QEMU_AUDIO_DRV and SDL_AUDIODRIVER in the > service file even after your changes goes against this principle. So what should be done about these? I think whoever added support for these environment variables a couple of

Re: [PATCH v6 3/4] remove sysconfig files

2022-01-04 Thread Olaf Hering
Mon, 3 Jan 2022 03:18:11 -0800 Andrea Bolognani : > The fact that we still QEMU_AUDIO_DRV and SDL_AUDIODRIVER in the > service file even after your changes goes against this principle. These variables are probably stale. But, I just looked briefly at the code and could not figure out within

Re: [PATCH v6 3/4] remove sysconfig files

2022-01-03 Thread Andrea Bolognani
On Mon, Jan 03, 2022 at 11:31:20AM +0100, Olaf Hering wrote: > Thu, 23 Dec 2021 10:29:33 -0800 Andrea Bolognani : > > On Tue, Dec 21, 2021 at 12:22:44PM +0100, Olaf Hering wrote: > > > -# If systemd socket activation is disabled, then the following > > > -# can be used to listen on TCP/TLS sockets

Re: [PATCH v6 3/4] remove sysconfig files

2022-01-03 Thread Olaf Hering
Thu, 23 Dec 2021 10:29:33 -0800 Andrea Bolognani : > On Tue, Dec 21, 2021 at 12:22:44PM +0100, Olaf Hering wrote: > > --- a/src/remote/libvirtd.sysconf > > +++ /dev/null > > @@ -1,21 +0,0 @@ > > -# If systemd socket activation is disabled, then the following > > -# can be used to listen on

Re: [PATCH v6 3/4] remove sysconfig files

2021-12-23 Thread Andrea Bolognani
On Tue, Dec 21, 2021 at 12:22:44PM +0100, Olaf Hering wrote: > +++ b/docs/daemons.rst > @@ -686,3 +686,23 @@ socket unit names into the service. When using these old > versions, the > +Changing command line options for daemons > += > + > +Two ways exist to

[PATCH v6 3/4] remove sysconfig files

2021-12-21 Thread Olaf Hering
sysconfig files are owned by the admin of the host. They have the liberty to put anything they want into these files. This makes it difficult to provide different built-in defaults. Remove the sysconfig file and place the current desired default into the service file. Local customizations can