Re: [RFC 0/1] Check for pid re-use before killing domain process

2022-10-11 Thread manish.mishra
On 11/10/22 10:17 pm, Daniel P. Berrangé wrote: On Tue, Oct 11, 2022 at 10:11:29PM +0530, manish.mishra wrote: Thanks for review Jonathon, Daniel On 11/10/22 9:56 pm, Daniel P. Berrangé wrote: On Tue, Oct 11, 2022 at 11:20:00AM -0500, Jonathon Jongsma wrote: I believe that pidfd syscalls

Re: [RFC 0/1] Check for pid re-use before killing domain process

2022-10-11 Thread manish.mishra
Thanks for review Jonathon, Daniel On 11/10/22 9:56 pm, Daniel P. Berrangé wrote: On Tue, Oct 11, 2022 at 11:20:00AM -0500, Jonathon Jongsma wrote: I believe that pidfd syscalls were introduced in kernel 5.2. Judging by our CI build setup, the oldest distrubution that we support is Alma Linux

Re: [RFC 0/1] Check for pid re-use before killing domain process

2022-10-11 Thread Daniel P . Berrangé
On Tue, Oct 11, 2022 at 10:11:29PM +0530, manish.mishra wrote: > Thanks for review Jonathon, Daniel > > On 11/10/22 9:56 pm, Daniel P. Berrangé wrote: > > On Tue, Oct 11, 2022 at 11:20:00AM -0500, Jonathon Jongsma wrote: > > > I believe that pidfd syscalls were introduced in kernel 5.2. Judging

Re: [RFC 0/1] Check for pid re-use before killing domain process

2022-10-11 Thread Daniel P . Berrangé
On Tue, Oct 11, 2022 at 11:20:00AM -0500, Jonathon Jongsma wrote: > I believe that pidfd syscalls were introduced in kernel 5.2. Judging by our > CI build setup, the oldest distrubution that we support is Alma Linux 8, > which still has kernel version 4.18. We need to support FreeBSD / macOS for

Re: [RFC 0/1] Check for pid re-use before killing domain process

2022-10-11 Thread Jonathon Jongsma
I believe that pidfd syscalls were introduced in kernel 5.2. Judging by our CI build setup, the oldest distrubution that we support is Alma Linux 8, which still has kernel version 4.18. On 10/6/22 4:33 AM, manish.mishra wrote: Libvirt stores pid of domain(e.g Qemu) process when a domain

[RFC 0/1] Check for pid re-use before killing domain process

2022-10-06 Thread manish.mishra
Libvirt stores pid of domain(e.g Qemu) process when a domain process is started and same pid is used while destroying domain process. There is always a race possible that before libvirt tries to kill domain process, actual domain process is already dead and same pid is used for another process. In