Re: [RFC PATCH 1/6] qemu_monitor: add qemuMonitorQueryStatsSchema

2022-09-07 Thread Martin Kletzander
On Wed, Sep 07, 2022 at 02:23:24PM +0200, Kristina Hanicova wrote: Hi, just a few notes on the code quality. On Wed, Sep 7, 2022 at 12:34 PM Amneesh Singh wrote: Related: https://gitlab.com/libvirt/libvirt/-/issues/276 This patch adds a simple API for "query-stats-schemas" QMP command Sign

Re: [RFC PATCH 1/6] qemu_monitor: add qemuMonitorQueryStatsSchema

2022-09-07 Thread Kristina Hanicova
Hi, just a few notes on the code quality. On Wed, Sep 7, 2022 at 12:34 PM Amneesh Singh wrote: > Related: https://gitlab.com/libvirt/libvirt/-/issues/276 > > This patch adds a simple API for "query-stats-schemas" QMP command > > Signed-off-by: Amneesh Singh > --- > src/qemu/qemu_monitor.c

[RFC PATCH 1/6] qemu_monitor: add qemuMonitorQueryStatsSchema

2022-09-07 Thread Amneesh Singh
Related: https://gitlab.com/libvirt/libvirt/-/issues/276 This patch adds a simple API for "query-stats-schemas" QMP command Signed-off-by: Amneesh Singh --- src/qemu/qemu_monitor.c | 29 +++ src/qemu/qemu_monitor.h | 35 ++ src/qemu/qemu_monitor_json.c | 93 +++