Re: [libvirt] [Libguestfs] [PATCH libguestfs v3] lib: Handle slow USB devices more gracefully.

2016-01-19 Thread Richard W.M. Jones
On Tue, Jan 19, 2016 at 05:00:27PM +, Daniel P. Berrange wrote: > On Tue, Jan 19, 2016 at 04:18:46PM +, Richard W.M. Jones wrote: > > Libvirt has a fixed 15 second timeout for qemu to exit. If qemu is > > writing to a slow USB key, it can hang (in D state) for much longer > > than this -

Re: [libvirt] [Libguestfs] [PATCH libguestfs v3] lib: Handle slow USB devices more gracefully.

2016-01-19 Thread Richard W.M. Jones
On Tue, Jan 19, 2016 at 05:57:17PM +, Richard W.M. Jones wrote: > But I think I should test `check_for_errors' instead, since that flag > basically means did we come from the guestfs_shutdown method -- where > we want to be careful about data integrity -- or did we come from the >

Re: [libvirt] [Libguestfs] [PATCH libguestfs v3] lib: Handle slow USB devices more gracefully.

2016-01-19 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 04:18:46PM +, Richard W.M. Jones wrote: > Libvirt has a fixed 15 second timeout for qemu to exit. If qemu is > writing to a slow USB key, it can hang (in D state) for much longer > than this - many minutes usually. > > The solution is to check specifically for the