Re: [libvirt] [PATCH/RFC] Introduce VIR_MIGRATE_FORCE flag to allow for risky migration

2011-10-25 Thread Daniel P. Berrange
On Mon, Oct 24, 2011 at 04:12:08PM -0600, Eric Blake wrote: On 10/24/2011 02:00 AM, Daniel P. Berrange wrote: On Fri, Oct 21, 2011 at 08:16:24PM +0200, Guido Günther wrote: Hi, Migration will be disallowed when the vm uses host devices or has snapshots (qemuMigrationIsAllowed)[1]. Would it

Re: [libvirt] [PATCH/RFC] Introduce VIR_MIGRATE_FORCE flag to allow for risky migration

2011-10-25 Thread Guido Günther
On Mon, Oct 24, 2011 at 04:12:08PM -0600, Eric Blake wrote: On 10/24/2011 02:00 AM, Daniel P. Berrange wrote: On Fri, Oct 21, 2011 at 08:16:24PM +0200, Guido Günther wrote: Hi, Migration will be disallowed when the vm uses host devices or has snapshots (qemuMigrationIsAllowed)[1]. Would it

Re: [libvirt] [PATCH/RFC] Introduce VIR_MIGRATE_FORCE flag to allow for risky migration

2011-10-24 Thread Daniel P. Berrange
On Fri, Oct 21, 2011 at 08:16:24PM +0200, Guido Günther wrote: Hi, Migration will be disallowed when the vm uses host devices or has snapshots (qemuMigrationIsAllowed)[1]. Would it make sense to introduce a VIR_MIGRATE_FORCE similar to VIR_REVERT_FORCE here? We could then introduce error

Re: [libvirt] [PATCH/RFC] Introduce VIR_MIGRATE_FORCE flag to allow for risky migration

2011-10-24 Thread Eric Blake
On 10/24/2011 02:00 AM, Daniel P. Berrange wrote: On Fri, Oct 21, 2011 at 08:16:24PM +0200, Guido Günther wrote: Hi, Migration will be disallowed when the vm uses host devices or has snapshots (qemuMigrationIsAllowed)[1]. Would it make sense to introduce a VIR_MIGRATE_FORCE similar to

[libvirt] [PATCH/RFC] Introduce VIR_MIGRATE_FORCE flag to allow for risky migration

2011-10-21 Thread Guido Günther
Hi, Migration will be disallowed when the vm uses host devices or has snapshots (qemuMigrationIsAllowed)[1]. Would it make sense to introduce a VIR_MIGRATE_FORCE similar to VIR_REVERT_FORCE here? We could then introduce error codes similar to the snapshot case (VIR_ERR_MIGRATE_RISKY). This path