Re: [libvirt] [PATCH]: Fixed minor bugs in display and added OOM checks.

2009-09-08 Thread Pritesh Kothari
Lastly added OOM checks in few places which were missed earlier. Okay applied thanks ! I would concur with Chris, I think the current practice in most of libvirt code when there is a complex routine is to handle OOM with a goto to an error label. Thanks Chris and Daniel for the review, i

[libvirt] [PATCH]: Fixed minor bugs in display and added OOM checks.

2009-09-07 Thread Pritesh Kothari
Hi All, There was a minor bug in selecting the graphics type. if the graphics type was desktop it was assumed that display is set for it, and thus crashed on strdup, so now checking if display is present before setting it. The second bug was while setting the 3d acceleration parameter,

Re: [libvirt] [PATCH]: Fixed minor bugs in display and added OOM checks.

2009-09-07 Thread Chris Lalancette
Pritesh Kothari wrote: Hi All, There was a minor bug in selecting the graphics type. if the graphics type was desktop it was assumed that display is set for it, and thus crashed on strdup, so now checking if display is present before setting it. The second bug was while setting the 3d

Re: [libvirt] [PATCH]: Fixed minor bugs in display and added OOM checks.

2009-09-07 Thread Daniel Veillard
On Mon, Sep 07, 2009 at 10:59:10AM +0200, Pritesh Kothari wrote: Hi All, There was a minor bug in selecting the graphics type. if the graphics type was desktop it was assumed that display is set for it, and thus crashed on strdup, so now checking if display is present before setting it.