Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-28 Thread Daniel Veillard
On Fri, Jul 25, 2008 at 04:09:31PM -0400, Guido Günther wrote: [PATCH] also check domain uuid on create and don't care if domain is active or not - it confuses users both ways Okay, that looks reasonnable to me, applied and commited, thanks ! Daniel -- Red Hat Virtualization group

Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-25 Thread Daniel P. Berrange
On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote: Hi, qemu_driver misses some conversions to a char* before printing the uuid. Possible fix attached. ACK, surprised that the printf() format checks don't complain about passing an unsigned char to a %s format in GCC. This is

Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-25 Thread Daniel Veillard
On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote: On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote: Hi, qemu_driver misses some conversions to a char* before printing the uuid. Possible fix attached. ACK, surprised that the printf() format checks don't

Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-25 Thread Guido Günther
On Fri, Jul 25, 2008 at 05:02:43AM -0400, Daniel Veillard wrote: On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote: On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote: Hi, qemu_driver misses some conversions to a char* before printing the uuid. Possible fix

Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-25 Thread Daniel Veillard
On Fri, Jul 25, 2008 at 09:56:27AM -0400, Guido Günther wrote: On Fri, Jul 25, 2008 at 05:02:43AM -0400, Daniel Veillard wrote: On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote: On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote: Hi, qemu_driver misses

Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-25 Thread Guido Günther
On Fri, Jul 25, 2008 at 11:46:48AM -0400, Daniel Veillard wrote: On Fri, Jul 25, 2008 at 09:56:27AM -0400, Guido Günther wrote: On Fri, Jul 25, 2008 at 05:02:43AM -0400, Daniel Veillard wrote: On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote: On Thu, Jul 24, 2008 at

[libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-24 Thread Guido Günther
Hi, qemu_driver misses some conversions to a char* before printing the uuid. Possible fix attached. Cheers, -- Guido --- src/qemu_driver.c | 25 - 1 files changed, 20 insertions(+), 5 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index