Re: [libvirt] [PATCH][take2][1/2] add virGetUIDByUsername() and virGetGIDByGroupname()

2009-04-16 Thread Ryota Ozaki
Hi Guido and Daniel, On Fri, Apr 17, 2009 at 12:07 AM, Guido Günther wrote: > Hi Ryota, > On Thu, Apr 16, 2009 at 11:24:10PM +0900, Ryota Ozaki wrote: >> +#ifdef HAVE_GETPWNAM_R >> +int virGetUIDByUsername(virConnectPtr conn, char *name) >> +{ >> +    struct passwd pwbuf; >> +    struct passwd *p

Re: [libvirt] [PATCH][take2][1/2] add virGetUIDByUsername() and virGetGIDByGroupname()

2009-04-16 Thread Guido Günther
Hi Ryota, On Thu, Apr 16, 2009 at 11:24:10PM +0900, Ryota Ozaki wrote: > +#ifdef HAVE_GETPWNAM_R > +int virGetUIDByUsername(virConnectPtr conn, char *name) > +{ > +struct passwd pwbuf; > +struct passwd *pw = NULL; > +char *strbuf; > +size_t strbuflen = sysconf(_SC_GETPW_R_SIZE_MAX);

Re: [libvirt] [PATCH][take2][1/2] add virGetUIDByUsername() and virGetGIDByGroupname()

2009-04-16 Thread Daniel P. Berrange
This looks like a good idea - just need to add the etra checking for case where sysconfg() returns -1, as per Guido's earlier patch for similar getgrnam_r usage. Daniel On Thu, Apr 16, 2009 at 11:24:10PM +0900, Ryota Ozaki wrote: > Signed-off-by: Ryota Ozaki > > >From de8c57e3a2c4e564ec989016c5

[libvirt] [PATCH][take2][1/2] add virGetUIDByUsername() and virGetGIDByGroupname()

2009-04-16 Thread Ryota Ozaki
Signed-off-by: Ryota Ozaki >From de8c57e3a2c4e564ec989016c547ad6754e43871 Mon Sep 17 00:00:00 2001 From: Ryota Ozaki Date: Wed, 8 Apr 2009 23:10:46 +0900 Subject: [PATCH] add virGetUIDByUsername() and virGetGIDByGroupname() --- configure.in |2 +- src/util.c | 57 ++