Re: [libvirt] [PATCH] (v2) avoid chowning domain devices if higer-level mgmt does it for us

2009-11-30 Thread Daniel P. Berrange
On Sun, Nov 29, 2009 at 03:54:30PM +0200, Dan Kenigsberg wrote: Only now did I notice another problem with root_squasing nfs, unrelated to chown and unadressed by my patch: qemudDomainSave tries to create the target image file and write into it as root. How reasonable would it be to seteuid()

Re: [libvirt] [PATCH] (v2) avoid chowning domain devices if higer-level mgmt does it for us

2009-11-29 Thread Dan Kenigsberg
Only now did I notice another problem with root_squasing nfs, unrelated to chown and unadressed by my patch: qemudDomainSave tries to create the target image file and write into it as root. How reasonable would it be to seteuid() to qemu user before doing so? -- Libvir-list mailing list

Re: [libvirt] [PATCH] (v2) avoid chowning domain devices if higer-level mgmt does it for us

2009-11-25 Thread Daniel Veillard
On Wed, Nov 25, 2009 at 09:27:13AM +0200, Dan Kenigsberg wrote: this is particularily important if said device is a file sitting on a root_squashing nfs export. my previous attempt for a patch missed 3 chowns that should be avoided. --- src/qemu/qemu.conf |4

Re: [libvirt] [PATCH] (v2) avoid chowning domain devices if higer-level mgmt does it for us

2009-11-25 Thread Dan Kenigsberg
On Wed, Nov 25, 2009 at 10:31:03AM +0100, Daniel Veillard wrote: On Wed, Nov 25, 2009 at 09:27:13AM +0200, Dan Kenigsberg wrote: this is particularily important if said device is a file sitting on a root_squashing nfs export. my previous attempt for a patch missed 3 chowns that should be

Re: [libvirt] [PATCH] (v2) avoid chowning domain devices if higer-level mgmt does it for us

2009-11-25 Thread Daniel P. Berrange
On Wed, Nov 25, 2009 at 01:38:52PM +0200, Dan Kenigsberg wrote: On Wed, Nov 25, 2009 at 10:31:03AM +0100, Daniel Veillard wrote: On Wed, Nov 25, 2009 at 09:27:13AM +0200, Dan Kenigsberg wrote: this is particularily important if said device is a file sitting on a root_squashing nfs export.

Re: [libvirt] [PATCH] (v2) avoid chowning domain devices if higer-level mgmt does it for us

2009-11-25 Thread Hugh O. Brock
On Wed, Nov 25, 2009 at 11:49:32AM +, Daniel P. Berrange wrote: On Wed, Nov 25, 2009 at 01:38:52PM +0200, Dan Kenigsberg wrote: On Wed, Nov 25, 2009 at 10:31:03AM +0100, Daniel Veillard wrote: On Wed, Nov 25, 2009 at 09:27:13AM +0200, Dan Kenigsberg wrote: this is particularily

[libvirt] [PATCH] (v2) avoid chowning domain devices if higer-level mgmt does it for us

2009-11-24 Thread Dan Kenigsberg
this is particularily important if said device is a file sitting on a root_squashing nfs export. my previous attempt for a patch missed 3 chowns that should be avoided. --- src/qemu/qemu.conf |4 src/qemu/qemu_conf.c |3 +++ src/qemu/qemu_conf.h |1 +